Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3600048pxk; Tue, 29 Sep 2020 00:52:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjB4zydM8xJccYPWgTsG1ORRBSsrwoKvk1/Bs6j5ewMlTYRxijGKDh9el4lw5BOUFhE2MR X-Received: by 2002:a05:6402:b64:: with SMTP id cb4mr1839491edb.25.1601365958351; Tue, 29 Sep 2020 00:52:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601365958; cv=none; d=google.com; s=arc-20160816; b=V3o0Eu/STzM8KiHvkSmRe6w7H4CJbGrHJK8lg0J2RxtCtBV0IkcJO1z5bnpxm4tydH 34T3mFtEDfzdWVrh04wkobVAQ0pAw6LX+gwHgOsIQqczdSiuwpeg5+lSeOgbVz8uv5Xe AfgG1879ssS9GTeDDdn1I2rNM13KcUVA38CUvDdyk8O1H/OWtv2rZC73jLJMgl1yp9+m yH4wnVtd0u1e4SKJnARmchSs+V/VH0T+Uzxl4wK3vnnpvrbm+aHnejfDHIJgGZfW1roh akZugW6DutRlruubWaOwI+VvytQPS70rpBK3hJy7JgxC36mo0KFDicmh6DQ/4KMCqInS P85g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=sWRNVHJHTp+wKQxionNUOGRw8/5V7sAwtL/3ylvbgjw=; b=cmzvi8rvhhHCTdKsXhoQ3cLz5jp1CbMq2hhtIwH5R0Aiey5+sxARp9mtbJv9D52ru7 dlxNCSEFo++/a+uwq7DKXfAy0JtHXpk5xCkAm5H+JKe8CXT0lErhPZGVZDvceTk7tW3B 8fozE8MJZ6dJVgSTu34mhbqHAIFCXgP12WQTP8vMBFoGheraDVsNHCBbXcAqo5UtREgr biyYEqaktK/M84w1V9R1GlounKyeC2DgiwCdeh30cVKAgsEKsnrE3vZcNFTpfZx+4mL3 9Yq/gUjMddN4IAU8fLw9uAdqzAxAobM8vVDNXvb+nSoPupo12yOLbn0x06HU7+dWL4Kx RN/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x23si2123758ejb.588.2020.09.29.00.52.14; Tue, 29 Sep 2020 00:52:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727495AbgI2Htr (ORCPT + 99 others); Tue, 29 Sep 2020 03:49:47 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:34138 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725554AbgI2Hto (ORCPT ); Tue, 29 Sep 2020 03:49:44 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B4E6BE01A41B648043A0; Tue, 29 Sep 2020 15:49:39 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Tue, 29 Sep 2020 15:49:29 +0800 From: Jing Xiangfeng To: , CC: , , Subject: [PATCH] staging: mfd: hi6421-spmi-pmic: Fix error return in hi6421_spmi_pmic_probe() Date: Tue, 29 Sep 2020 15:48:47 +0800 Message-ID: <20200929074847.47124-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return error code -ENOMEM from the error handling case instead of 0. Signed-off-by: Jing Xiangfeng --- drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c index 64b30d263c8d..4f34a5282970 100644 --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c @@ -262,8 +262,10 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev) hi6421_spmi_pmic_irq_prc(pmic); pmic->irqs = devm_kzalloc(dev, HISI_IRQ_NUM * sizeof(int), GFP_KERNEL); - if (!pmic->irqs) + if (!pmic->irqs) { + ret = -ENOMEM; goto irq_malloc; + } pmic->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0, &hi6421_spmi_domain_ops, pmic); -- 2.26.0.106.g9fadedd