Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        andrew.smirnov@gmail.com
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2] tty: serial: lpuart: fix lpuart32_write usage
Date:   Tue, 29 Sep 2020 17:19:20 +0800
Message-Id: <20200929091920.22612-1-peng.fan@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SG2PR06CA0177.apcprd06.prod.outlook.com (2603:1096:1:1e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Tue, 29 Sep 2020 08:52:59 +0000
X-Mailer: git-send-email 2.28.0
X-Originating-IP: [119.31.174.71]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 0f0a42d2-76ff-4dec-2df1-08d864551277
X-MS-TrafficTypeDiagnostic: DB7PR04MB4091:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DB7PR04MB4091352AEC059E3D9771E7BA88320@DB7PR04MB4091.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:462;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: DC6VHcoV0r3G6+PNjcm9fTWyp1yn5+Aul2cKNAjORDltjgHQ2OKXNWPz172SeAbvssUVoC6pIdfg6T0YgAAQxKP7MGhUQZh0iA3FpPmWcs/5ysFiQeFbrrIcuEIIBkR1Xm+7UaSbfhycHuZuuIldFTcodLlygjXgtJI5oFQM2fm12u8cKmOfQdyG5VASNecxJPVwukE7cIQIEUph1FXYnTulZvvBw/PR+TTblcIbuEv89d3RSgAC4Th7RPPipK04KfJQQjXWlRE8tAZ7X1rlmERU0NjZHC+9g3gJceu0zt0jBmAPj8aySverXL/TuhmE8HVcWF4CPUWqcHPEK/GIfA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0402MB2760.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(6512007)(86362001)(66476007)(66556008)(66946007)(5660300002)(8676002)(6486002)(8936002)(26005)(16526019)(186003)(36756003)(4326008)(316002)(44832011)(478600001)(2616005)(52116002)(83380400001)(6506007)(1076003)(956004)(6666004)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: hwAw5kliYRDjHb5KuhTE9flDcDfKi4cpUZ1RWnn61J7PvTpHiruiI5AT9FGRCeNYnoUCQR5BFoBhuzzjB5S3KUZZ6MwI4CGKhjW8vah3JYNlq4Dkxvj3OOqspMSm3BJZEzIq6ZZ5SopDOhoAbgnVuHgqEx3TP3ZJishIMs4VGryZdaz+N6KseE34oAc69btksHLBLEKRfxV7Zu/P8/T7AijyoovHO7oPvNI30ZcUNgAq2vIGfIZ3D6zMwJau/e0b8gArnIjAgSb77V3lI6ZUwP4iYJdeCLtFlzyqh95fqYV039EartrYv4CgSY4qTQAwpMfWMDYwe2a/o1W2QZyny0BTihYqAnM7DWWAv8ynsGoGVQ14qVcUxjSPFS6HhTfgcfOgIHZm6NMZUuGl8HBvYOmVv240jBfMVrt1VUA1Z1CfQI78qNTuRQBCyJhdLYT2QkrJYgtxw+IbjmmYhOe1WND0BNMEPC93Rkm0LPruAoqUMn+6uxN/e5o3OQzRd0UK2xfCUNnemQJgDS5jBJ3FtRV+ohbNlFHb/waoHQghK+5h/qJEtVnE9vT0UUF6AvQbwvATPVjq6f1OEKmxusnicaJRm+qweL0ClWdjj3gI0T2CnBc+XMH0P/AiYl8CIFjaU85Mc5BE+o5ifO8Obf7yLw==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f0a42d2-76ff-4dec-2df1-08d864551277
X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2020 08:53:02.2031
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h7+iX+ueM+qijINzdbdtZaAdjZdCv3GWFz9lL/AiH1Xt3DqzibTONvPqVU+OpeuRBD4ZeHI8dro2r1lk+C74UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4091
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The 2nd and 3rd parameter were wrongly used, and cause kernel abort when
doing kgdb debug.

Fixes: 1da17d7cf8e2c4("tty: serial: fsl_lpuart: Use appropriate lpuart32_* I/O funcs")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Fix poll init

 drivers/tty/serial/fsl_lpuart.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 5a5a22d77841..645bbb24b433 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -649,26 +649,24 @@ static int lpuart32_poll_init(struct uart_port *port)
 	spin_lock_irqsave(&sport->port.lock, flags);
 
 	/* Disable Rx & Tx */
-	lpuart32_write(&sport->port, UARTCTRL, 0);
+	lpuart32_write(&sport->port, 0, UARTCTRL);
 
 	temp = lpuart32_read(&sport->port, UARTFIFO);
 
 	/* Enable Rx and Tx FIFO */
-	lpuart32_write(&sport->port, UARTFIFO,
-		       temp | UARTFIFO_RXFE | UARTFIFO_TXFE);
+	lpuart32_write(&sport->port, temp | UARTFIFO_RXFE | UARTFIFO_TXFE, UARTFIFO);
 
 	/* flush Tx and Rx FIFO */
-	lpuart32_write(&sport->port, UARTFIFO,
-		       UARTFIFO_TXFLUSH | UARTFIFO_RXFLUSH);
+	lpuart32_write(&sport->port, UARTFIFO_TXFLUSH | UARTFIFO_RXFLUSH, UARTFIFO);
 
 	/* explicitly clear RDRF */
 	if (lpuart32_read(&sport->port, UARTSTAT) & UARTSTAT_RDRF) {
 		lpuart32_read(&sport->port, UARTDATA);
-		lpuart32_write(&sport->port, UARTFIFO, UARTFIFO_RXUF);
+		lpuart32_write(&sport->port, UARTFIFO_RXUF, UARTFIFO);
 	}
 
 	/* Enable Rx and Tx */
-	lpuart32_write(&sport->port, UARTCTRL, UARTCTRL_RE | UARTCTRL_TE);
+	lpuart32_write(&sport->port, UARTCTRL_RE | UARTCTRL_TE, UARTCTRL);
 	spin_unlock_irqrestore(&sport->port.lock, flags);
 
 	return 0;
@@ -677,7 +675,7 @@ static int lpuart32_poll_init(struct uart_port *port)
 static void lpuart32_poll_put_char(struct uart_port *port, unsigned char c)
 {
 	lpuart32_wait_bit_set(port, UARTSTAT, UARTSTAT_TDRE);
-	lpuart32_write(port, UARTDATA, c);
+	lpuart32_write(port, c, UARTDATA);
 }
 
 static int lpuart32_poll_get_char(struct uart_port *port)
-- 
2.28.0