Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3633514pxk; Tue, 29 Sep 2020 02:03:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzcrP8gKQwNLn6mGWr6x7eAJ309WebJi0NDFoLYAHxmUCHcHmeD1SesFKts19VWCJXA+Lu X-Received: by 2002:a17:906:c007:: with SMTP id e7mr131778ejz.55.1601370209351; Tue, 29 Sep 2020 02:03:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601370209; cv=none; d=google.com; s=arc-20160816; b=P8DjX/rfB7u0nXl6WycoJr2CygRwNeIc2/GvSBhGal4D1mXrsnYMnFcExPurg9uyjZ iP9biwMblBm32Y7zGMzdB9LV0Q563Q1A9HcoNi++3kGxsj/kMQ+/UfWbCRo8zXvRBSvX wFUx61Kr3Do89YyPeWUEOcltBkv3cZyQycRorH0ZfvSdAqBnAFD1NBjPBEHSZI3/GM0H ucz7VyWiOvmBJW1DBriGN8ZpypBk+tq22IBjomRMqvlpDu9pkjMdg91yxMivlD5gF0yf YJEvWX1aELPbpi4+2xcJL2qdg4EF51Gk/smAc5QF67Vp37uExePNqM1krHuzkf4JFraF rvvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5KNvUcSgp+Lvmv+qjj1zdke2aHNUW1BUoc+MUCQvxjE=; b=vP2ZBQHFxLshToORUAGYRtGMt/bK4JLGvsqRmG9f+ClW4Z6TtccSmbf6Ymkk8NF7Z0 tthpTQ+7O3Jqxeu5bdqUqwFQIJamVFSGdzrrx8KBw4N1QjGYVKUpaOwb6ZdqJtHGcR3+ bJ9oyp4Wn8HUGUjZ1SuZsfTasVi2rLYMyp3ImN8KxTS3ryrEVUhKK0R4pdP4KqbHDK18 fumtd+ljCtN0JmtYzTLfG6NRNLNv7+D52JesLEJlqguGM/8o7suORj2gpuWrQd8iVXmj TBmZJmZVHHJ5ydVBO9J2MyDoj5VzoFSF4LfjD5tMkaKG2UQOnAZaWV23KkbR1CsM4L2s uPSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=AP96ceqO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si2288960edy.478.2020.09.29.02.03.06; Tue, 29 Sep 2020 02:03:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=AP96ceqO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727724AbgI2JCA (ORCPT + 99 others); Tue, 29 Sep 2020 05:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgI2JCA (ORCPT ); Tue, 29 Sep 2020 05:02:00 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D04E6C061755; Tue, 29 Sep 2020 02:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5KNvUcSgp+Lvmv+qjj1zdke2aHNUW1BUoc+MUCQvxjE=; b=AP96ceqOEmxM6wO0nh0hPUEoLX vIuH8jJzPpEMRoYZhYdPHgc7RELo0PtBxCUr2X/RF/P5ug/JntAt+8VbA6OJd4rFHtV+nRYqg0oXU Z5JclqfAGLldmR9TFhIcxHeEphbifT9CnMCHNxIYe8+mFmTVyycb34p98cQd4kSX4ylTGsqjcAZO7 wcApx2C0OSQpd0KgJLrQuHzUoG/6vZvaQalO0krGZRcnKPJQ2X5lW3mgAulfWewKsIEPRPd17HYjS hAOotp947BHDwE3i3S+MS2QIog8GuQYXIXQEUwyiOFFAGGCFKpdu1BkW2jMqAcsQepkGHBFoDDz9K /hJSeU/A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNBVv-0006Db-Ou; Tue, 29 Sep 2020 09:01:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 36211300F7A; Tue, 29 Sep 2020 11:01:33 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E0E2520115B18; Tue, 29 Sep 2020 11:01:33 +0200 (CEST) Date: Tue, 29 Sep 2020 11:01:33 +0200 From: Peter Zijlstra To: lihaiwei.kernel@gmail.com Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, pbonzini@redhat.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, Haiwei Li Subject: Re: [PATCH] KVM: x86: Add tracepoint for dr_write/dr_read Message-ID: <20200929090133.GI2611@hirez.programming.kicks-ass.net> References: <20200929085515.24059-1-lihaiwei.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929085515.24059-1-lihaiwei.kernel@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 04:55:15PM +0800, lihaiwei.kernel@gmail.com wrote: > From: Haiwei Li > > Add tracepoint trace_kvm_dr_write/trace_kvm_dr_read for x86 kvm. This is a changelog in the: i++; /* increment i */, style. Totally inadequate.