Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3644809pxk; Tue, 29 Sep 2020 02:26:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyazypSPRCfxgkX2WDTvvPhuaWddb23FNWrf59Gxop8dCiN6EI2pKVdYMLlC2N4pySYLEJi X-Received: by 2002:a17:906:2c01:: with SMTP id e1mr2992717ejh.128.1601371565298; Tue, 29 Sep 2020 02:26:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601371565; cv=none; d=google.com; s=arc-20160816; b=XUhSujzq3Klfssql5m5sHHRXPFThDqMr+UUY7z7zp7zC6VD0lb6Mbm/uVTIEpXgvIu yOUuadazQZV6AVANKqW80fAy3kdXKjtNoWJF5RPhZWHqDDQ5GXMYV/q6H5H5qEXFLRGS DVSoZgiwezlSo7ubLqo6aHl5t6P1HJkl+WZR4U2U8jRGHKZg/8eu0Qf26vjjQPZUmdCM F6t62rhas5bmqnLcV4edKpMlXhzs3YwyJol6GrdBkmJTL/2AUyoCoB8XKhcz3jPV6hNG zRH6D/wrn9YsSzQ/1qI9+ZPsbKntyWfetj4YeqXPWDDz0UtK3qBh2xx+UyG/CIlOfaPf qU3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=CO/UKz/jXJjJsaVu2uUjJkwpPwsf41ZrUDzoTgfrll0=; b=AlgfdxcplSoZZjuoJHNB/+dFF7e5NmHQMkFcTW3ftN0lAvSCv2rc6O0cgeD6QF3eff bCxMWkvy/DarW5Rk3MXkssGKQlF9ohfJvF2Divt04hTNT55qYzwH4knSdWCIrQudLPOS X5pi/+5m+N/xnBINpm6Zxj+9QiuhBkwCVLLBpnaA+7WDvkwltPkfzYU4p+kppkxjJCsL EzlWfCHCi7Tm6C5CugxQbzUlFpTpuTI9NFiO5YmZ+SijijRGllf/82VywX2/MdsKBysm 0L+cQUJH5zSzj+BS7l4OrXQJWbwUpdgmBla7amdv+r/09arTGKj8pWvIbDKqfMOfPNcI wRyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si2701943edl.230.2020.09.29.02.25.42; Tue, 29 Sep 2020 02:26:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727914AbgI2JWf (ORCPT + 99 others); Tue, 29 Sep 2020 05:22:35 -0400 Received: from ns.iliad.fr ([212.27.33.1]:53170 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbgI2JWf (ORCPT ); Tue, 29 Sep 2020 05:22:35 -0400 X-Greylist: delayed 554 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Sep 2020 05:22:34 EDT Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id C65262043B; Tue, 29 Sep 2020 11:13:19 +0200 (CEST) Received: from [192.168.108.70] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id B628C20035; Tue, 29 Sep 2020 11:13:19 +0200 (CEST) Subject: Re: [PATCH v2 2/2] spmi: fix some coding style issues at the spmi core To: Mauro Carvalho Chehab , Stephen Boyd Cc: John Stultz , Manivannan Sadhasivam , MSM , LKML References: From: Marc Gonzalez Message-ID: Date: Tue, 29 Sep 2020 11:13:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Tue Sep 29 11:13:19 2020 +0200 (CEST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2020 08:22, Mauro Carvalho Chehab wrote: > @@ -487,7 +489,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl) > continue; > > sdev->dev.of_node = node; > - sdev->usid = (u8) reg[0]; > + sdev->usid = (u8)reg[0]; typeof(sdev->usid) is u8. What is the point of this cast? Does GCC warn that u32 is being truncated to u8? Regards.