Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>
CC:     "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] tty: serial: fsl_lpuart: fix lpuart32_poll_get_char
Thread-Topic: [PATCH] tty: serial: fsl_lpuart: fix lpuart32_poll_get_char
Thread-Index: AQHWlkLyXL3SRNaDbkiNzzmUP3/mFql/WwmQ
Date:   Tue, 29 Sep 2020 09:36:23 +0000
Message-ID: <AM8PR04MB73157339D0AC240C3DAAD64BFF320@AM8PR04MB7315.eurprd04.prod.outlook.com>
References: <20200929095509.21680-1-peng.fan@nxp.com>
In-Reply-To: <20200929095509.21680-1-peng.fan@nxp.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dbb4659c-d9c2-405d-c0ea-08d8645b2185
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 09:36:23.9314
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4FQp0JZVoKlKmzkyMP0As6ViYAzWR10rXI5Rv88Lqkm8SizK6oqZlrWgSbYIYJ9s4e0o8dCm1a+W5Xj79Dlucw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6274
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Peng Fan <peng.fan@nxp.com> Sent: Tuesday, September 29, 2020 5:55 PM
> The watermark is set to 1, so we need to input two chars to trigger RDRF =
using
> the original logic. With the new logic, we could always get the char when=
 there
> is data in FIFO.
>=20
> Suggested-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/tty/serial/fsl_lpuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpu=
art.c index
> 645bbb24b433..1c37280b6c0c 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -680,7 +680,7 @@ static void lpuart32_poll_put_char(struct uart_port
> *port, unsigned char c)
>=20
>  static int lpuart32_poll_get_char(struct uart_port *port)  {
> -	if (!(lpuart32_read(port, UARTSTAT) & UARTSTAT_RDRF))
> +	if (!(lpuart32_read(port, UARTWATER) >>  UARTWATER_RXCNT_OFF))

Please remove redundant blank space.

>  		return NO_POLL_CHAR;
>=20
>  	return lpuart32_read(port, UARTDATA);
> --
> 2.28.0