Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3658223pxk; Tue, 29 Sep 2020 02:53:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzK80H73ot4pb34FHa1xx36HpQTLI9Xcn0lAESUE8G5eDCaxkiwhpZqNu280wzkzs147uTw X-Received: by 2002:a05:6402:1219:: with SMTP id c25mr2369820edw.220.1601373208828; Tue, 29 Sep 2020 02:53:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601373208; cv=none; d=google.com; s=arc-20160816; b=dTlNiO6HO5gmkmlC84EX2/Ffkxu954solpn7nXKzk2JI6pMX+g7qESwIMIeB0ngR0y Kgp2GCsSHeDPWsXVmQPB18m1DygvmVbnfIpBek+Qjj5JaxUvu/dyzv/3naGxpCtgFazG gHvqbAO+9xp/oaFgFYVnXP+mjcwDJi28anthLL3IXxQljZ7TptHbiEFG2O/0/iDWm+qw tYuV53TUXx3N3dxMBuhrqg247oBNEJBsGAfn1sH8BsFdkNeOOhYvre2TzfsUqcF48uEG sDo39kPvbjyh/NuDu0bFEB+9GV8l+GB76wmS03d2Su0SkjAlfnobZZIpdwj0cQOJI26h McLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q7VcobJF6uyWmgL5vmwuoyYLR7D7rwBPhHFHQDDI+jU=; b=eMXrn3DhNeNa0WD8uXqSQez1ymmYEQAzTO50X9SLnFXmYIz6SZ4EdXmKKniuI1ebzK bEl4cMObWDpDYfl5iPqBJ4Vq8BN35Kmb3pjzrffbOKuVTiIM+vt1WDWFeyEFKaYXjFLf Gz1hR+JGWNsY4x9tCqnuk4isthm5ARSJV5J/YofGhdIHxCznNnAwCUcSaYgiKUjahw+o Pqb4dUOdxJdrqBCTgVQjmdIVyGquM8yNusWho329+8h5cRjIJ9yhIGDIcjkqZEdRgSAK QJNF+TZi2SC5eCNhhmGTVy+3GX8glf0onFuE20TiIXe8BVTtvScpVIyH6Zonj+6rRF+9 Q37A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WvSTpYhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si2235572ejb.541.2020.09.29.02.53.05; Tue, 29 Sep 2020 02:53:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WvSTpYhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727983AbgI2Jva (ORCPT + 99 others); Tue, 29 Sep 2020 05:51:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50163 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727660AbgI2JvY (ORCPT ); Tue, 29 Sep 2020 05:51:24 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601373083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q7VcobJF6uyWmgL5vmwuoyYLR7D7rwBPhHFHQDDI+jU=; b=WvSTpYhmbBOKXQX9qewutzU9/aj+rMPezrax/1XhwKdE0YPBW8WZa+XwVY+PHdzp5WGLUQ 8Sijo9sAnKFFkWgq2VJJ1Oqtj7ihvfLnHLzo0QG0kH6lToC2AzNuBqKnQlDOwt0MvfysHo ++QqXROfMmWxdSVEOIzGWHt/QMHLQpA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-vkhqYCmMOjSawZD1UYOkUA-1; Tue, 29 Sep 2020 05:51:21 -0400 X-MC-Unique: vkhqYCmMOjSawZD1UYOkUA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4DC8801AE3; Tue, 29 Sep 2020 09:51:19 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6EDE47880B; Tue, 29 Sep 2020 09:51:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AC8AA358099; Tue, 29 Sep 2020 11:51:15 +0200 (CEST) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: Gerd Hoffmann , Dave Airlie , David Airlie , Daniel Vetter , Huang Rui , =?UTF-8?q?Christian=20K=C3=B6nig?= , virtualization@lists.linux-foundation.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), spice-devel@lists.freedesktop.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 4/4] drm/qxl: use qxl pin function Date: Tue, 29 Sep 2020 11:51:15 +0200 Message-Id: <20200929095115.24430-5-kraxel@redhat.com> In-Reply-To: <20200929095115.24430-1-kraxel@redhat.com> References: <20200929095115.24430-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Otherwise ttm throws a WARN because we try to pin without a reservation. Fixes: 9d36d4320462 ("drm/qxl: switch over to the new pin interface") Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c index d3635e3e3267..eb45267d51db 100644 --- a/drivers/gpu/drm/qxl/qxl_object.c +++ b/drivers/gpu/drm/qxl/qxl_object.c @@ -145,7 +145,7 @@ int qxl_bo_create(struct qxl_device *qdev, return r; } if (pinned) - ttm_bo_pin(&bo->tbo); + qxl_bo_pin(bo); *bo_ptr = bo; return 0; } -- 2.27.0