Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3673007pxk; Tue, 29 Sep 2020 03:20:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzapOe/9wNselfg9/ny++NPan+WccSjeCOaa/ehxvlwaRQ+yin1ZXvrVPXYc/1xn61ZBLc7 X-Received: by 2002:a17:907:110f:: with SMTP id qu15mr3262672ejb.359.1601374828900; Tue, 29 Sep 2020 03:20:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1601374828; cv=pass; d=google.com; s=arc-20160816; b=CzEFG1GPLEHa2RRWDsqYuZ9fOQm9oqKogtW5FLxm4OoIvWGoWu3c5g6897bxjLPUoC pt3umth/R1DKDdUiADRecLI9ph1d7pypQizPCovRrUBYtpAX/9KOFISfDmWn7icGNgnv 9cJbVV8OFP4PiG3V9vIIT0BMTUWFczrOrSh7wLZafvy8s+SW9Jf09Cw6svr6J9l49vOo 8N+7IUdNUZ8oXgV96XBD8PKsTU2R6CazKqRrayiMUemvAGyLAchih4SNmLt90HaQjKB2 TWyavrIp2ud85YJaIANX5sKwKDyBQZAR7t7MWVqA3iU8BBdVj+q9BYZdJGCOpyPxSWKO EMEQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=O3iJiqycZZlziR3GK/QHx/x1sCdpq0ltYBozgvTzKN0=; b=O2eyhlvgUK2mJlVnSREML+Lph76zUlzsSXbaBdpB4rndwR17uT9+MCf/uhE+R2CKNt y3g4WFMSDTWKIQAs3XCdETYAoyMmy3e6a3Dv8Jgd1fqUazpHpqeqtKmoKyqw2aI7mqAc khPm/8iQiWo9sTBi5xtLwaY4wQbCtOntDpYpTHNK0NUprTHuBA1POqZL/iGLzoOi4W7w K9dA2PPgqVW36V9EgJn/aATIHsYIjYjew+lFl+ol0axvsqw8He3y4iRSFop9Inu6e5d6 BEZwsYSOt48ORkP9X/TrZzOGmIzlE0VufZE7UPxrQcleKi6jgkdM0OC6HXzyiO007yup QNow== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b="lmpWI/Fk"; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x18si2348572ejn.61.2020.09.29.03.20.05; Tue, 29 Sep 2020 03:20:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b="lmpWI/Fk"; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727851AbgI2KTD (ORCPT + 99 others); Tue, 29 Sep 2020 06:19:03 -0400 Received: from mail-eopbgr60065.outbound.protection.outlook.com ([40.107.6.65]:37203 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725497AbgI2KTD (ORCPT ); Tue, 29 Sep 2020 06:19:03 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bhN/nS+Nq0VrL7aEnNDkNpqM89RFNNBm8nbXvLdSLLQ79ahV0HvsAuU/HMMiQe6anq/rV9ed/vJkgnbQncCGEgnA9wdDsuJ6d9X/zaac/j2wzS5nyS0a1SeHqDyC/tt0wea4MSYs4BdfCszec6gA3fVDeKiSz1CB4q1GIJqhpUTe7HOIuqnYdg9OL31tbQNnOsFEw06V6EFW/LADkOf5rV+x7dqc5aRuJXQ6Kh9KaN72LIcgeRi8yJMffjuFTu1t/7gxOCcdGKoBgGxXm+lUVqJtvzlk/beoXwFoHMjrcRfZ4DRpSuglDwQ4SVfhGTqsKQA6adxdiXlJd7Rwf4j/Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3iJiqycZZlziR3GK/QHx/x1sCdpq0ltYBozgvTzKN0=; b=WOquIaVbXlCSyz6aCrOGARaFYJ6JrtKy8lsK0Wd5DxxxvHo0aQV+H0MFYPcJ/sZrkD7zRMzRjNwACOVkJlz8/WPORM3SGpA53LOHoldg4U/5XasucVcATTx0SYLiJeINA/4rbcR70ky+r8kyxINTrfuDemAh7M0MnwvrB4xQTNuvWIj5v3JN2KAP2pNxyOJ7eLDlg+vbo80pDAf2LZIfTcihsfWPTY2AtKgFmA/c9z9MSPvfW3JRowOD0cRCu5Ak3p7b2YGcHs4rivHv2vgIg5fvE5lFybmi6yPhCGt1rKMV4zyf5ezqv31+i4fLNc/zJmSikyj9JSxicoxXCzc96w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3iJiqycZZlziR3GK/QHx/x1sCdpq0ltYBozgvTzKN0=; b=lmpWI/FkZ/8dseAghmasaUiswE9gxD94A+hfv8oXexkhZ1c1jqwt9iMsAoh8kRyDXD/hkN4tczHYJhaYqW4GFkjVaIjKDOfjkMC6bT4tjza0q417sZT3L4b37R9SBXcBTG9/EPrZGhfv27/8qtxG8FQkzfL45Ojl3oAgDYGcKYw= Received: from DB6PR0401MB2438.eurprd04.prod.outlook.com (2603:10a6:4:33::14) by DB8PR04MB6907.eurprd04.prod.outlook.com (2603:10a6:10:119::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Tue, 29 Sep 2020 10:18:59 +0000 Received: from DB6PR0401MB2438.eurprd04.prod.outlook.com ([fe80::c8a:a759:d4ba:181e]) by DB6PR0401MB2438.eurprd04.prod.outlook.com ([fe80::c8a:a759:d4ba:181e%7]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 10:18:59 +0000 From: "Biwen Li (OSS)" To: Guenter Roeck , "Biwen Li (OSS)" CC: "jdelvare@suse.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Reinhard Pfau Subject: RE: [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan controller Thread-Topic: [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan controller Thread-Index: AQHWlknykGKAx8F3l0ypnNqJIqmdbw== Date: Tue, 29 Sep 2020 10:18:59 +0000 Message-ID: References: <20200928104326.40386-1-biwen.li@oss.nxp.com> <20200928162839.GB106276@roeck-us.net> In-Reply-To: <20200928162839.GB106276@roeck-us.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: roeck-us.net; dkim=none (message not signed) header.d=none;roeck-us.net; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a7d9d6f1-b0f9-4503-e009-08d8646114a7 x-ms-traffictypediagnostic: DB8PR04MB6907: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KxHy2TJNRis0Sb1iqG2X1wb3jnBoMOw6S1xhReA9S5ftqphEi9kvCdOzHZXtm4ublWKt2zj/0R7FIm+m0nhbhHXsU1jd6RFwgCTT1IBA3fxOHbFuDg7vcBe4t8L2ASFhFL33rOvD0FVYprGZI0pcpVhG/N6wV4tHyB/jIdjk9zAzs8z3j8x+rQXkvWtVXWQ44cNiflVykNitx6p+cUuz+H/eGJJIi1PmugvL6WCbg/4G2r64+kjOfVPUIpfTYEYYD4hUv+mAbJc9q5nW+Z15TkMLxaKl2ZtPAdAlmw7bC668puHfwMyzpgW/6E5+KvRM4bSdHbtD+0RxCwdDVeICk2y0pi0kphflytBPRavpIMn9imqgWepvJHYUDjPdp2Pi x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0401MB2438.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(396003)(366004)(346002)(55016002)(6506007)(54906003)(110136005)(33656002)(26005)(316002)(76116006)(8936002)(7696005)(186003)(66946007)(5660300002)(8676002)(478600001)(9686003)(71200400001)(52536014)(2906002)(4326008)(558084003)(66476007)(64756008)(66556008)(66446008)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: fqmMgs4xCxmiuRB5Li18JPyx9vDQbfzzXEdl3USTxUrexaXP0pUYepsIItNtJGDRdxRCDwad2YbXOU+K6zs3aFyn66gT4ES+uuoFdne3j/3cVQilsQwWix4WVZE/TLzoWsITEvIdSvUiANE8fHpMCM3rLaynRepZGO54v9CNs77pxFsz8NZXWmQtwcFsYPX1cXHFy2CbSWNtql4sogOY1BMiuk7GYQZ+YsQq5mkUO0vxnlshI3gg9fCm3gIRRTVCIIaWaSnmsIk9Qe1N0ng1iG2foVQcYFxxqvXe8Jtqqvcn3BnM16fQwi8Z13FC8hUqwolooxEBvtFxfal/n6nB7Bjpq0wf3VIfJuNkjmwCrIEZSIPtlZn3wFwYZna6QU38jQ5KRZ+/joNLURUAouBSFcUU4DISY/Pge7M+1gH2XOwjxxnN5Awlp3KhTqG2bX6+16VcAJ+Rw4JV1Fx8QmvMvnN+HbF6K3MuCv6XjDeB4++DCtul//oJLZR4tjZsUK2m/wMb3Ag61RHrx2kxVA3YhI1q+eM7sgjgdxpZSa7kp3kvf9nEJvvV0j9BGyHGWDKQabaAME9K2yWGy2DSipfxfj2KcgeFWCXeRz/J2VCY4C5V+g0kGIML+/nHupb1IpXej2LVnPx963SBSATvs35EFQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0401MB2438.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7d9d6f1-b0f9-4503-e009-08d8646114a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 10:18:59.3576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PYaBaI1oV7qA1RLNnet3aGuB4a1Y5eeJd2srf/POnXZpwGQ2p1Gi4gxfXezVvoYoQLlzyX0A3iW1jPavjeau4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6907 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + > > + hwmon_dev =3D devm_hwmon_device_register_with_groups(&client->dev, > > + client->name, data, > > + data->groups); >=20 > New drivers must use "[devm_]hwmon_device_register_with_info" to register > with the hwmon subsystem. Hi Guenter, Got it, thanks. Best Regards, Biwen Li >=20 > Guenter