Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3677004pxk; Tue, 29 Sep 2020 03:28:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNLxvjtBKpWjmHieZL4H1kMvSliUdEzQIaYwKOXpix1bfoLNpZY9XeECiEsehpf/SrYhl9 X-Received: by 2002:a17:906:850:: with SMTP id f16mr3038414ejd.447.1601375295608; Tue, 29 Sep 2020 03:28:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601375295; cv=none; d=google.com; s=arc-20160816; b=k46l9vQ+Komr1LHhLYL5OYajUdlh19CZtQFM8ZONzJpFMoo/bqb5Or4k1y66e61fIF f1oz2mVftrNZlmDcDNBW1BswF3IAPW1gGbO00n1zj8aAJHbBNlVMzYvTP0ofLLRWHP0i NOkpSQwxcQIPHgZwXOYKWs2Zg8VAHh3gS2XvqZLtHd+HskDPAt+8N2EExjPRLtJwPkC5 L2mFsVG4JFVMl8oQhsbxNHlRmBY7Sh//QHPlZuJiNwze3ldE+MVP7epoGRJYvUrybHuw 016cPhlwy8pQDZcfwfw7zLiOnXU+A7O9B3ZbK0YUdIDcy+Nzd2eduCcBGLdhFladc0eK ZXqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=t81ZZuNzpJLl7eqXLt4Rpz6twCeoEwW6ubQucuoX+Lw=; b=XRl0e4fGx9DYB5+qk+81BJJBw5qjDe9qkR8KFN1aplNTtNLuCTiYww9VkH08ylN7tr CA55Gf9fancxQoAOVH8t4npXUkvivyA/b38reFCR/sh1myn/fbODxCvbeuNp2i2QPkRl 9obwcdF88KX6Y+KsAVpvpryvD88CUbQK9mfyC0lqcZFF+kb3f7bhCS3WxAx2zWQDv/1t QHCVNEr9yQ1zfZVe6WdLgcClRd8aDVTFUebG6UsqBGlGOE4amfHNVV6irjSQ5/5A4610 zr5y9Elj3w+gZMXj7+BOhqi1exkpB66SD9Smdxb8SBxTyYtBp/YfZy8nq9psc37HOcBy XpCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j4l13kRc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si2317196ejr.560.2020.09.29.03.27.52; Tue, 29 Sep 2020 03:28:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j4l13kRc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728140AbgI2KYu (ORCPT + 99 others); Tue, 29 Sep 2020 06:24:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:60950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgI2KYu (ORCPT ); Tue, 29 Sep 2020 06:24:50 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A35292076A; Tue, 29 Sep 2020 10:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601375090; bh=pchBtxfISE/wCym8h42pDOZ5DqiOc1ZqjONMxC0swIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j4l13kRcluZ3Fwxae2U08F0y1EUdSbDNl7CA7RXe5cpAm0Zu2bVp33U2ulvmt5SuX PwWgkXULPdpt1ty1nXBsb2qja9BXviFsF1VdYESy84r5lUFl1EjiXVmD0rLdpkd8iv 4BxF0YBKuGs2fDPywOfYaP9becf4Lv5gmOosOnds= Date: Tue, 29 Sep 2020 12:24:55 +0200 From: Greg Kroah-Hartman To: Scott Branden Cc: Arnd Bergmann , Kees Cook , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Desmond Yan , James Hu Subject: Re: [PATCH v3 2/3] misc: bcm-vk: add Broadcom VK driver Message-ID: <20200929102455.GA951772@kroah.com> References: <20200825194400.28960-1-scott.branden@broadcom.com> <20200825194400.28960-3-scott.branden@broadcom.com> <20200907125530.GC2371705@kroah.com> <767f6b6a-07fc-f1b6-f43c-b974761f1505@broadcom.com> <20200924050851.GA271310@kroah.com> <8ce85527-cb0a-7cf4-541b-b346e060e772@broadcom.com> <830c5d91-eb45-8569-fc91-19b5b43cbcd7@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <830c5d91-eb45-8569-fc91-19b5b43cbcd7@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 05:22:12PM -0700, Scott Branden wrote: > > > On 2020-09-24 2:40 p.m., Scott Branden wrote: > > Hi Greg, > > > > Responses below.? I'll send out the split up patches hopefully today/tomorrow > > which may make it a bit easier to understand/comment on. > > > > > I have split up the patches and sent out patch v4. > Hopefully this is more understandable split up and you understand the rationale for > a misc driver and a tty driver to support this PCIe card. I still don't, but I'll respond to the patch, as it's easier to explain that there :) thanks, greg k-h