Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3681969pxk; Tue, 29 Sep 2020 03:37:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3LJxQqzBxK/eUCZqbaL0TirtEXzphYIMgw55egcK4hQ1muvrdVMD14JMo2BzYnxES3vza X-Received: by 2002:a17:906:4046:: with SMTP id y6mr3330888ejj.148.1601375873647; Tue, 29 Sep 2020 03:37:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601375873; cv=none; d=google.com; s=arc-20160816; b=Gt4HnB1qDJxkuTVAGQsMncihE7/Ipe9uQ3EtvDAiYMTZuXvn7ZMe9ZXgclipbeYdkb nPpNZugfwPyhtEeu39IDnVwnFTaW08o1U3GDt9BxKPU18gZ96GxXGtgZfdlDsl+dvT7T NMo0NeP3W+g5hCZylA3/BE5AJb2xeIXBBEMb3Zsy/jHfHGWXNOPpOEMOT3CGb3fH28IF xRBo7xoRw4lrjzM8rE1xxClp6CNAh11+9KgroeyhEhSBSBWX24aP9YOVnCUMbDxrsGct /7D8JsLt8clhRR+axMWceuK8nR4bPtX5R5QewP9SRYF+mpqlYr4mVIGTXdJCVvPNOrjQ uTeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oQK6HgsGFDUgQfZHeX/0UbNbz2EdE6vw31481lNb3gQ=; b=v5pd2yoM2c+Hv6khCTUBQLc/tl/nKnlATpXRKnaqIACnR3blJ9RKmruYY/YFReivF8 PRpVPJQ1Fpxx2r/4BSc1WIHsTjAnCCQ8mkBz3umVhsgs42gk6wG0tsNW7O2z/7j/OSsR 2DxcmkPNL87fN6es50q5w3xuVBGP/8iVz18kv+b+a3xmQofpsbzolDYv0Rbk/iuNuGIO s7c2zGuoKZuHroP0dBJZiJkjixm46iPKJ4PKS4Ev0nxgaNamKbf/FlxzU8hSxNOioL3u sO71lBe0Fja9KEIbugwXwArYvlIdCrYtQrIfzge6hq+HGV4lzbcciFi6S90zhL8qkrtp ASyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=t39Ob8b9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw21si2388854ejb.392.2020.09.29.03.37.30; Tue, 29 Sep 2020 03:37:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=t39Ob8b9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728186AbgI2Kfz (ORCPT + 99 others); Tue, 29 Sep 2020 06:35:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:42794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgI2Kfy (ORCPT ); Tue, 29 Sep 2020 06:35:54 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8CF02075F; Tue, 29 Sep 2020 10:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601375754; bh=u4myyC2FCs6IeunqeNEz8KzBIYzR3949I//QihYj6Wc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t39Ob8b965lJzHVgrp91VQv3HZgivaKc4BiOwFS1n7y4qtVKlA5fTteqGxoeTICnf Il/sc9legvzzDNaoFyM1N/o9c8LxHhttwZTH3LiYcwywKN3ietVy4UMKvywhl39kiY xuRac5zW6X8o8oRZdBZfTi1KqrUZBq3flLJ1IXGA= Date: Tue, 29 Sep 2020 13:35:49 +0300 From: Leon Romanovsky To: Christoph Hellwig Cc: Doug Ledford , Jason Gunthorpe , Jens Axboe , Keith Busch , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, Sagi Grimberg Subject: Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code Message-ID: <20200929103549.GE3094@unreal> References: <20200929091358.421086-1-leon@kernel.org> <20200929091358.421086-2-leon@kernel.org> <20200929102046.GA14445@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929102046.GA14445@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 12:20:46PM +0200, Christoph Hellwig wrote: > On Tue, Sep 29, 2020 at 12:13:57PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The RDMA vector affinity code is not backed up by any driver and always > > returns NULL to every ib_get_vector_affinity() call. > > > > This means that blk_mq_rdma_map_queues() always takes fallback path. > > > > Fixes: 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity") > > Signed-off-by: Leon Romanovsky > > So you guys totally broken the nvme queue assignment without even > telling anyone? Great job! Who is "you guys" and it wasn't silent either? I'm sure that Sagi knows the craft. https://lore.kernel.org/linux-rdma/20181224221606.GA25780@ziepe.ca/ commit 759ace7832802eaefbca821b2b43a44ab896b449 Author: Sagi Grimberg Date: Thu Nov 1 13:08:07 2018 -0700 i40iw: remove support for ib_get_vector_affinity .... commit 9afc97c29b032af9a4112c2f4a02d5313b4dc71f Author: Sagi Grimberg Date: Thu Nov 1 09:13:12 2018 -0700 mlx5: remove support for ib_get_vector_affinity Thanks