Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1a69c3fa0291f991ffcf113ea222c713ba4d4ff0.1598264917.git.michal.simek@xilinx.com>
In-Reply-To: <1a69c3fa0291f991ffcf113ea222c713ba4d4ff0.1598264917.git.michal.simek@xilinx.com>
From:   Michal Simek <monstr@monstr.eu>
Date:   Tue, 29 Sep 2020 13:01:32 +0200
Message-ID: <CAHTX3dK__pxO8HBDgKkokGD823Y7jDCF_cncbE74NsF1yYQwfw@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: zynqmp: Fix leds subnode name for
 zcu100/ultra96 v1
To:     U-Boot <u-boot@lists.denx.de>, git <git@xilinx.com>
Cc:     Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
        Rajan Vaja <rajan.vaja@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        linux-arm <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

po 24. 8. 2020 v 12:28 odes=C3=ADlatel Michal Simek <michal.simek@xilinx.co=
m> napsal:
>
> Fix the leds subnode names to match (^led-[0-9a-f]$|led).
>
> Similar change has been also done by commit 08dc0e5dd9aa ("arm64: dts:
> meson: fix leds subnodes name").
>
> The patch is fixing this warning:
> avnet-ultra96-rev1.dt.yaml: leds: 'ds2', 'ds3', 'ds4', 'ds5' do not match
> any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> vbus-det led is not fixed because it is not LED. It should be likely
> handled as gpio hog.
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm=
64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d60110ad8367..2352dc553ba7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -56,27 +56,27 @@ sw4 {
>
>         leds {
>                 compatible =3D "gpio-leds";
> -               ds2 {
> +               led-ds2 {
>                         label =3D "ds2";
>                         gpios =3D <&gpio 20 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger =3D "heartbeat";
>                 };
>
> -               ds3 {
> +               led-ds3 {
>                         label =3D "ds3";
>                         gpios =3D <&gpio 19 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger =3D "phy0tx"; /* WLAN tx */
>                         default-state =3D "off";
>                 };
>
> -               ds4 {
> +               led-ds4 {
>                         label =3D "ds4";
>                         gpios =3D <&gpio 18 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger =3D "phy0rx"; /* WLAN rx */
>                         default-state =3D "off";
>                 };
>
> -               ds5 {
> +               led-ds5 {
>                         label =3D "ds5";
>                         gpios =3D <&gpio 17 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger =3D "bluetooth-power";
> --
> 2.28.0
>

Applied.
M


--=20
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs