Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3698535pxk; Tue, 29 Sep 2020 04:08:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+4NXNzWCGWZI4Z6zZdNl9Akiem4A3Ds1mGq+a5uO4lK3Q9R55wdvfIS3FTB62v37ceys/ X-Received: by 2002:a17:906:4154:: with SMTP id l20mr3506732ejk.68.1601377684291; Tue, 29 Sep 2020 04:08:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601377684; cv=none; d=google.com; s=arc-20160816; b=b7OCo7M2g/+ZHlMSI4vpCQD3UFDOIzOK1izaotvqPs6qPxb1yk2FmIubPMuV7krtY4 hdfkctBAYCZ8eA2i9sDgL0HV4UaaI355jRTG7K1EoUmSU1XUWOG7J7Z/SfO4nFXMYxzj GFRGmxRc7d631S+vYD+wStCPmXJsmA7v/Vvkfs8k9VUgB934ujEJAZWDkUU7blGTE44e 77uAXVb+gEAGQaEzeDT7UhAh/ysiargIl6hUSGJIsOOUTW0aBw6VIkAc8/Ej/42oZq1k bbkD+wCyDmcLRLdDJMYWdaH9PrE6Oi0XsS5+jZp04AriwNocihfPabonfQg3yVmyjjmZ sg5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CwLMTeeuKk9JrZVjsV68Oxv996sJ8Pf7UaskgV2DKXc=; b=CmTWZM5zefOuKi3pRhDVVmUGkpr0u7pcDomX27DOjufLnS2ahfn22O+kwqEBt6616E 63jFScd4o0BOjjk+XuENx80MmAbzP3kbixcSRqvkmVV/zwfm51puRLR4wepKpLodJ+3z d70P9HdFjZjFMjxVY+avqyheOGIpwJzkWcXi6TS60fPpLbh2tT0nI/xdrZJFr6XlwqPA 0aoKP6dDmCJL3+/9uPY0KVCsXkyrtA+SqoWHPYH6MKIq9rZgxeBXaxia2Uf+gr99oyKB DzpUHdN639V3XesisL/xnK+uBgz7HM2x97I5fQ+EbhvpPDVPouMA6PKTKh52RD9MTlkX 5+jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KBRKwrpX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f23si2520026edm.413.2020.09.29.04.07.41; Tue, 29 Sep 2020 04:08:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KBRKwrpX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728542AbgI2LEA (ORCPT + 99 others); Tue, 29 Sep 2020 07:04:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:39798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728515AbgI2LDx (ORCPT ); Tue, 29 Sep 2020 07:03:53 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 600A021734; Tue, 29 Sep 2020 11:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601377433; bh=t+hjMmfyg01UEJQInIr+fsuyXy/91PgQueFshlKGzlA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KBRKwrpXeP5cunpJRqFfQsBCm4WtnFE6Qs2moyy62czkFxlKbxkhj8ehJ3CiLLihp /99r/CLUXlw9RMcTT4uhMkawQMsaZmaoIYakC0Eqzc/bpLQx9wBVUtCK8Vecx8mWYl iwiEuKal+yrIpjDtiAdxqbnrempLIDnVxEQE+UQA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , "David S. Miller" Subject: [PATCH 4.4 09/85] net: add __must_check to skb_put_padto() Date: Tue, 29 Sep 2020 12:59:36 +0200 Message-Id: <20200929105928.681246288@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105928.198942536@linuxfoundation.org> References: <20200929105928.198942536@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit 4a009cb04aeca0de60b73f37b102573354214b52 ] skb_put_padto() and __skb_put_padto() callers must check return values or risk use-after-free. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2651,7 +2651,7 @@ static inline int skb_padto(struct sk_bu * is untouched. Otherwise it is extended. Returns zero on * success. The skb is freed on error. */ -static inline int skb_put_padto(struct sk_buff *skb, unsigned int len) +static inline int __must_check skb_put_padto(struct sk_buff *skb, unsigned int len) { unsigned int size = skb->len;