Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3699039pxk; Tue, 29 Sep 2020 04:08:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4VngFdo23LACwzdR9gLN9RY5O98pvr897JZv5GhKHZHDu0BKz1WLMVEDrlK8Xwy+C+ogz X-Received: by 2002:a17:906:e18:: with SMTP id l24mr3238197eji.334.1601377736926; Tue, 29 Sep 2020 04:08:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601377736; cv=none; d=google.com; s=arc-20160816; b=bUYz+PeClzzZxd7bZvE1UL2hl2sA+HKuoGDKjT7mGEJwyMMA4bEWdcxppgZDwsXXbk +7m6qsUBDrhxZAObFzKHsNMmQzmjhV202UXz15mxQF0pQIZKbbwEc1XF+5CgbGXFQpA6 AvgzLIYgONoOEYRy75ryheLk51eemgKEdihs9QVBDXX/A3wxNcD7/KQXwPn1qmsa40cI Y99pIs1z9Yi8FRfmp4Qf8K/J8x7tsMY5nUdjO8whRRTqrMIprhpHu0QMw5W7jnN9jb5N AFe8kl/YiibwO3TgjXO6i4QWchIOLAOc+Fa9uRpZ9hocvPai3wWTqUbNyDe/IBvyA5/9 RUJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=550C7SYsnGqBtGXY5jfUWqylLOhC/Yg+UCrzKcelNSE=; b=bt3u1SDPVwWgOTmt+GrVbWcoWgXHmS+bMOjcb6A3FLisW1rAc/R0uGIRMSwjnTm2Jq NJFlEkiLixGzLFIlXSafUsfRZISD1tMX6Cuwy6H2pMkapCsak+dQcZPN52f+bqWXHsfP KI/0fwp8kCH7ij+x9HnMbYpFAXIia1ObzHYCyLy6zqaro1gjgDsqR4YGJRFwt8UMza86 54uE2axkEav8k7eQ7BWchjdpewSU06ymDL713fXimxWn4mbAtV/4Ag2uMl0lJ7BPGXAH wFXAwtThBE33l0Ji6GLCv8s3qyBkRlIrjGGxn1aDRLGyNx/nTkmjS662f5HX83vK4Cps oI9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ARrTQIL/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si2374625eju.153.2020.09.29.04.08.34; Tue, 29 Sep 2020 04:08:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ARrTQIL/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728479AbgI2LG1 (ORCPT + 99 others); Tue, 29 Sep 2020 07:06:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:42006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728734AbgI2LFd (ORCPT ); Tue, 29 Sep 2020 07:05:33 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F23320C09; Tue, 29 Sep 2020 11:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601377530; bh=bJmLIFgkps+uvZwlLZlyfVmMQ0zhPoXU7BMyDWH1xm0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ARrTQIL/hSlurt5qrlkieyqo1bwtEOs3H7UjiQwHfhRLo5tfIZjBbZ12Cv/Un/CgO zH8WS3hGreFsfHWB9U3/MK8YFCG1TdrKq8H5lPy+zvHBH40X2zjRYJJ5B0K5YK+VWf pGb9j523hg02UMiOlXRgmFVe7IV4NtywhywAcnHM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthew Wilcox , Miklos Szeredi , Sasha Levin Subject: [PATCH 4.4 61/85] fuse: dont check refcount after stealing page Date: Tue, 29 Sep 2020 13:00:28 +0200 Message-Id: <20200929105931.262811710@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105928.198942536@linuxfoundation.org> References: <20200929105928.198942536@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi [ Upstream commit 32f98877c57bee6bc27f443a96f49678a2cd6a50 ] page_count() is unstable. Unless there has been an RCU grace period between when the page was removed from the page cache and now, a speculative reference may exist from the page cache. Reported-by: Matthew Wilcox Signed-off-by: Miklos Szeredi Signed-off-by: Sasha Levin --- fs/fuse/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 8142f6bf3d310..fc265f4b839ae 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -850,7 +850,6 @@ static int fuse_check_page(struct page *page) { if (page_mapcount(page) || page->mapping != NULL || - page_count(page) != 1 || (page->flags & PAGE_FLAGS_CHECK_AT_PREP & ~(1 << PG_locked | 1 << PG_referenced | -- 2.25.1