Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3701055pxk; Tue, 29 Sep 2020 04:11:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwu6T1YFBEb8Yp57uAcewM+RBI8K1H3IOdeMiWm2UrkTE02iYnoZcnVfbpeltj4nd72+hXj X-Received: by 2002:a05:6402:1694:: with SMTP id a20mr2562876edv.286.1601377916191; Tue, 29 Sep 2020 04:11:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601377916; cv=none; d=google.com; s=arc-20160816; b=F1Xj0/WFtKN+X7hv/ksJIBDFXZD2hntJnfgTTmfDimJ2WZKgE1I/XTnEYNHSJYwge7 a6oAWUos7huGwccXveU4dVjq1OvVeV8iD3w/9vZSh7NQa5Exp/POFDoyXrGgOXBcTjnG mEKJqPtGRBZaV9JbPlMUXrxwMZkzgRktPkasGfR0uxitG6wPecq34FMRqgj0oH2kxWri c9eZyjTRVwXT8Ti1sm72pmeMLJ5GM68WU8prjl+hWBtEWO3ZTqjyqaHxUqFjbSkaGBP4 30f70yNjK8uIiW+/9WNkB6+QEEqoSHLEIhqiKs2LBy3peK8G2wZMv3NwnQgzWf2SFcsu wa+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ta7sHKz8TGQJzZxGw+3R6ZijfbbZLXhqojheVZBWfNQ=; b=pOJjUXUnrgevmrCOdMrypSUnx3oR1RnI4z/fpJoaz5fovd8GVKaxkt7m5S7bGCmzXv YI+/FmVeK9l3KShAj0cH1yLiDRgqp3ymsk07KlA/Mr3GlGxgdBB3PeYbDGLnFtfhKNZg E4OQKzKgaoiLt/h8KySBXYkJqhlFdlwo+kUJWZ/lkJwKB0xgqedo1aNUQc629fB/oGUe MQ1OutozcF2wGAG2+EWIivE4jooIzieknXrz7cDXMNqm5eqDBXkGh6UZqhV8s9PnUsg0 WXSGmPWXqkb4+OE6zqLR58Al/JvPoBB/+KnBcMkCUa/fzFXTnwAjTbixppEAx2BUjF+j b7AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VR14s7Om; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id os2si2482131ejb.112.2020.09.29.04.11.33; Tue, 29 Sep 2020 04:11:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VR14s7Om; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728882AbgI2LHC (ORCPT + 99 others); Tue, 29 Sep 2020 07:07:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:44842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728552AbgI2LHA (ORCPT ); Tue, 29 Sep 2020 07:07:00 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F1FE21941; Tue, 29 Sep 2020 11:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601377619; bh=Id1n6rf2mWSjm9sPa5X++geLufjs9SgNuL3/iStXyaY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VR14s7OmYADZZ7vqByfU96H/327enHGIEd+ns/tipNtiorjjYe3Z8dBq+35uYa8F7 L3jzcAUHawSBoNmn9LeTIaVeuKdhmixgVxDytQeu+GZC5I37O6uo/FAQjaX3m1K/ke pJGpiE8CerWB/MOmKNtgE/qRqA7l/Wg5L8wbu5mI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , "David S. Miller" Subject: [PATCH 4.9 012/121] net: add __must_check to skb_put_padto() Date: Tue, 29 Sep 2020 12:59:16 +0200 Message-Id: <20200929105930.790779331@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105930.172747117@linuxfoundation.org> References: <20200929105930.172747117@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit 4a009cb04aeca0de60b73f37b102573354214b52 ] skb_put_padto() and __skb_put_padto() callers must check return values or risk use-after-free. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2795,7 +2795,7 @@ static inline int skb_padto(struct sk_bu * is untouched. Otherwise it is extended. Returns zero on * success. The skb is freed on error. */ -static inline int skb_put_padto(struct sk_buff *skb, unsigned int len) +static inline int __must_check skb_put_padto(struct sk_buff *skb, unsigned int len) { unsigned int size = skb->len;