Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3703582pxk; Tue, 29 Sep 2020 04:15:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAXBdFMmwt86tgFiSJZea/SPHJaKl6qwr7aNnRhNoCNtxdKLpaWxGCcbDa8bEzlVO3y4y+ X-Received: by 2002:a17:906:82c1:: with SMTP id a1mr3233570ejy.270.1601378127998; Tue, 29 Sep 2020 04:15:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601378127; cv=none; d=google.com; s=arc-20160816; b=NkCaQXCyk9JULtHnHWmnE8t554RFCXGASetCszY8VWaNdyXa1hCIk0GXqKe04V5CGp WTAarFpzTMtURcftUZ8QCCupsMTp2/4nMx4v7EAaES/LjqvrPBeWvIpnrpf9VJS/bo0D HyvyMXQrrmQ27Xv/0qTarVOkwBwq9HNcisQF2H3vimwx7J8e24/Ewu9uU1r6WNvwIZWR SLnkmVpQQljm9C0b8wCIZrt9dW109mGJQ4SNOwGYLBWqErwXVkHAplMhi2VgUK1Mv0vu jvgupSxWfdOZDXbmyHffrOcazUaclfaBqhtFij4cj+SvZDt/0GKMkG9RgtQwDKrqmhJF bR/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OBwUZTrBfT3ZHj0oc2X3vpyPZqvYEci3XFajJta0VUs=; b=nlM8tAAWnSkHy8BbBJEpFWaNrqF3i1gQnX2crNyMfTXubi9op3HCPpcpj5VqQXJsk9 vbM+3SPvpEIAh3u9JamGUjwBdpeTGueJ5URYOMbXN0lmnDPk4xuGpEM3RlehjLnyVu4T UkBbbQJ8orlhylD7f6WXXb9po/DdcBdBQyD3eeOJ7rcanJSPd90EUGeVZgvG8Z8ibwxJ Z2/3uxh5lTyfN5P6l7vF50w/xUZWzF/GnpIH1HHzOnxrgSjFqvPcU6oT5ZPZmWu56E6N quvRqluupYoWatN7yiOlIrqLwmuo1HhhVCMXsntKa/HZfRp45DdbW8QfyBR3sxDU9gE3 eAng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AwvZFOAI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l24si2668094eji.478.2020.09.29.04.15.05; Tue, 29 Sep 2020 04:15:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AwvZFOAI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728938AbgI2LK5 (ORCPT + 99 others); Tue, 29 Sep 2020 07:10:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:51846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728440AbgI2LKs (ORCPT ); Tue, 29 Sep 2020 07:10:48 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B2D321924; Tue, 29 Sep 2020 11:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601377846; bh=c2YLg0AsSkbgQMOgwIODyvJuPjxfusS+oKmE9libKpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AwvZFOAIkiT8FIdzRNEqXEYmPmjkrqNzF8za+VSGCyjPfRcpQjxHCmDxtJB7ooMPN w9VbEPBJyI242aq01t7tP3w6NDm6BW1RdLCuXLddPUpk/COv+ZcJRyvS2xYUr4ExUO SMKLDaflST62QpRIkmPoJevV9++wSNpkccQms40M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adrian Hunter , Alexander Shishkin , Borislav Petkov , "H. Peter Anvin" , Jiri Olsa , Leo Yan , Mark Rutland , Masami Hiramatsu , Mathieu Poirier , Peter Zijlstra , "Steven Rostedt (VMware)" , x86@kernel.org, Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.9 094/121] perf kcore_copy: Fix module map when there are no modules loaded Date: Tue, 29 Sep 2020 13:00:38 +0200 Message-Id: <20200929105934.847549877@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105930.172747117@linuxfoundation.org> References: <20200929105930.172747117@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Adrian Hunter [ Upstream commit 61f82e3fb697a8e85f22fdec786528af73dc36d1 ] In the absence of any modules, no "modules" map is created, but there are other executable pages to map, due to eBPF JIT, kprobe or ftrace. Map them by recognizing that the first "module" symbol is not necessarily from a module, and adjust the map accordingly. Signed-off-by: Adrian Hunter Cc: Alexander Shishkin Cc: Borislav Petkov Cc: H. Peter Anvin Cc: Jiri Olsa Cc: Leo Yan Cc: Mark Rutland Cc: Masami Hiramatsu Cc: Mathieu Poirier Cc: Peter Zijlstra Cc: Steven Rostedt (VMware) Cc: x86@kernel.org Link: http://lore.kernel.org/lkml/20200512121922.8997-10-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/symbol-elf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 5a50326c8158f..e155783c601ab 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -1421,6 +1421,7 @@ struct kcore_copy_info { u64 first_symbol; u64 last_symbol; u64 first_module; + u64 first_module_symbol; u64 last_module_symbol; struct phdr_data kernel_map; struct phdr_data modules_map; @@ -1435,6 +1436,8 @@ static int kcore_copy__process_kallsyms(void *arg, const char *name, char type, return 0; if (strchr(name, '[')) { + if (!kci->first_module_symbol || start < kci->first_module_symbol) + kci->first_module_symbol = start; if (start > kci->last_module_symbol) kci->last_module_symbol = start; return 0; @@ -1559,6 +1562,10 @@ static int kcore_copy__calc_maps(struct kcore_copy_info *kci, const char *dir, kci->etext += page_size; } + if (kci->first_module_symbol && + (!kci->first_module || kci->first_module_symbol < kci->first_module)) + kci->first_module = kci->first_module_symbol; + kci->first_module = round_down(kci->first_module, page_size); if (kci->last_module_symbol) { -- 2.25.1