Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750992AbWHGDOF (ORCPT ); Sun, 6 Aug 2006 23:14:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750994AbWHGDOF (ORCPT ); Sun, 6 Aug 2006 23:14:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:35457 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1750993AbWHGDOE (ORCPT ); Sun, 6 Aug 2006 23:14:04 -0400 From: Andi Kleen To: Rusty Russell Subject: Re: 2.6.18-rc3-mm2 early_param mem= fix Date: Mon, 7 Aug 2006 05:13:52 +0200 User-Agent: KMail/1.9.3 Cc: Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org, Len Brown References: <200608070455.44237.ak@suse.de> <1154920106.21647.13.camel@localhost.localdomain> In-Reply-To: <1154920106.21647.13.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608070513.52068.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2027 Lines: 40 On Monday 07 August 2006 05:08, Rusty Russell wrote: > On Mon, 2006-08-07 at 04:55 +0200, Andi Kleen wrote: > > On Monday 07 August 2006 04:54, Rusty Russell wrote: > > > On Sun, 2006-08-06 at 18:22 +0100, Hugh Dickins wrote: > > > > but I wonder how many other early_param > > > > "option=" args are wrong (e.g. "memmap=" in the same file): x86_64 > > > > shows many such, i386 shows only one, I've not followed it up further. > > > > > > Thanks Hugh. > > > > > > Andrew, here's that i386 fix: > > > > I had already fixed that one and the x86-64 ones. > > > > But it still doesn't boot on x86-64 - gets into an endless loop > > at boot. I'm suspecting the code can't deal with duplicated > > prefixes. > > Works fine here: 32bit works for me too, but x86-64 does. Strangely it seems to somehow reenter head64 copy_boot_data. Perhaps stack gets smashed somehow? It goes into an endless loop of: Bootdata ok (command line is ip=dhcp nfsroot=10.23.204.1:/home/nfsroot/gaston root=/dev/nfs debug vga=0x0f07 rw pci=noacpi earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 earlyprintk=serial,ttyS0,115200 console=tty0 BOOT_IMAGE=bzImage ) Bootdata ok (command line is ip=dhcp nfsroot=10.23.204.1:/home/nfsroot/gaston root=/dev/nfs debug vga=0x0f07 rw pci=noacpi earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 earlyprintk=serial,ttyS0,115200 console=tty0 BOOT_IMAGE=bzImage ) Bootdata ok (command line is ip=dhcp nfsroot=10.23.204.1:/home/nfsroot/gaston root=/dev/nfs debug vga=0x0f07 rw pci=noacpi earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 earlyprintk=serial,ttyS0,115200 console=tty0 BOOT_IMAGE=bzImage ) etc. That is with all =s removed in early_params (i got that wrong in a lot of cases -- the only option I tested was apic which didn't have it) -Andi > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/