Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3757539pxk; Tue, 29 Sep 2020 05:39:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTxvl03g8IlSQA8tXnYN0/KPTq2Sb2pY10JgpTF1fedGE3gtPwgXBT2iCA7VWv5VPue5Qa X-Received: by 2002:a17:906:6d17:: with SMTP id m23mr3552724ejr.418.1601383178738; Tue, 29 Sep 2020 05:39:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601383178; cv=none; d=google.com; s=arc-20160816; b=cc3Rja/J0+rF+UBqUY2a5F+ppVo7OLxa/ftde4ckZo44Sct8z6uK7tUCyEvKUAtV9i 25HKfg5r3ekE5AHT0ijEES2I+4KWqYFut9dRKbHxbjMzLQhUQrZKjh3czSHwQZvSoiPI ZbqQta0rIb8LnQ3oErp0knAkbEYmBexUiA3iovXkMp+aWk6Y8NVaLBHkj7jxd5cV4NUj Z+xJ+H7ewMs6zp+KcAkkqBTjM1L3lmwOngxtIv2C5bQ8mXBZJUteST4vzBxp8czt7oaU KUkpmn/bHMIPQIfqoxdDpV7VrbrNThw0M0ydh64GAJv5pG4b1HbkhHB+mmSh+FnhBJdq cHxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MVnXdbWer9nfpNygbrypiX4zND37XcipHyC1yCr+vb8=; b=z0bxK+efWqW+26KqHSUbtf+Kn1jCFgM+bGLmsI2n/HQw/BMR5zfD2AYpXsF1fBv/Vi KX4qPlbqzsb/+q+asyNZfm/XdK7xOR6NTZfXiQq6BlfBb5p5sluUmKiuqeWsVPLPQil4 ZiG6MQBfspJYSt2Efyfvki75oqoyst/3Lm4VJGk7MSUhfwabqunDddrfFqKXYP6Npxs4 jqvW1xNpEAOgqVNkB8WMVZgcj1BuDvUKBRtpA3W+kU1alukCvaEGN6J7bUN8e2yEzss3 NO6WBdjR4jVAOH5D04GDrjwhcsbtK0BjSbv66XvPwLCMZL7QuJ6eQVEpMOXM78rg82lJ wVsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2HulgX1x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s26si2690657edw.32.2020.09.29.05.39.15; Tue, 29 Sep 2020 05:39:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2HulgX1x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733086AbgI2MiW (ORCPT + 99 others); Tue, 29 Sep 2020 08:38:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:34310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728783AbgI2LR1 (ORCPT ); Tue, 29 Sep 2020 07:17:27 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BEE8206A5; Tue, 29 Sep 2020 11:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601378246; bh=yj/lYPazjcLxTYPDL2xayjRqc9FZe9CiFPn3FykP1nQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2HulgX1x78HrRo/58cvcCT07BfD9xNCGJUUgbFNXt4hMuxNiJf1UbTKdP7MRLjsPN O2yUz9tPx1552ip1KZdW06+cFKpUbgF9MMHK4eafWbm0jbPVCodiXv0li2B5XHqjp/ ncbfeDip24M8y/nLqQMLGsCcJCu/lnfnhVp6Gxog= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Bakker , Sebastian Reichel , Sasha Levin Subject: [PATCH 4.14 112/166] power: supply: max17040: Correct voltage reading Date: Tue, 29 Sep 2020 13:00:24 +0200 Message-Id: <20200929105940.791432575@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105935.184737111@linuxfoundation.org> References: <20200929105935.184737111@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Bakker [ Upstream commit 0383024f811aa469df258039807810fc3793a105 ] According to the datasheet available at (1), the bottom four bits are always zero and the actual voltage is 1.25x this value in mV. Since the kernel API specifies that voltages should be in uV, it should report 1250x the shifted value. 1) https://datasheets.maximintegrated.com/en/ds/MAX17040-MAX17041.pdf Signed-off-by: Jonathan Bakker Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/max17040_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c index 33c40f79d23d5..2c35c13ad546f 100644 --- a/drivers/power/supply/max17040_battery.c +++ b/drivers/power/supply/max17040_battery.c @@ -109,7 +109,7 @@ static void max17040_get_vcell(struct i2c_client *client) vcell = max17040_read_reg(client, MAX17040_VCELL); - chip->vcell = vcell; + chip->vcell = (vcell >> 4) * 1250; } static void max17040_get_soc(struct i2c_client *client) -- 2.25.1