Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3760099pxk; Tue, 29 Sep 2020 05:43:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxivWlhQeTk/hQS+In6FiWNvUYtQhh1sRiTamyXxb12CmXBHX43lU/32A9r8NRj0o5PigxE X-Received: by 2002:a05:6402:164d:: with SMTP id s13mr2990402edx.222.1601383425655; Tue, 29 Sep 2020 05:43:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601383425; cv=none; d=google.com; s=arc-20160816; b=jquXiHzTVGKmBcoQMVeRVY5JfE9582ISGOaxLKQcPk7C7AgM4kf6yTBFX6UUlURBE2 Tq/OxlL7xNZZz4VESFhNDPXW7TufdQKCl97QdTzpcu9sp5n5Czs6C5HFJwUazyPIPGmp gDIVOL9C2bBEHI5geTje7Y2Cvh51i2kdtfrxrwPijEtWOtfrOSFeBHD6kPEfyDOLcnbW QEQjx8jaJu3cCf3dn6+Oj6cK3Rxk+dD+gMEM9e9EtEncOZ0UIC+Jw7WwchsoaY4fGR5D 2EZ9ToscSSt7RbzWlqMzYgtU3EZteltZmR0+L8OhSDvbb5IYN6Y5Sj+7Y29R1yb/uINZ Kf0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=moiRmHFLK4Bei3LouyEVvJ83NRlNw57gp4Z0mIsZW+s=; b=U5VJSaJQIdGVzBUdZJRXaRBMCmuuLb1+Lhc2///ejUuEgZa24fKfdUwRWDORm9PDTl GFYWBYyyDAkK9bqj+BxE31REugeDq5dTLCJJ/4MezD0gkPCEA9DKHteH7Vtu8rse5hbd PqopgGX4+RT4z/FjGjLkGv2YOMfTqd3aZZbWfrsS00UXNPsXJy8xFjPmuYsbnCiWrLkd bzb5Up0g1nkmbdCVENqjy59U8UTreb5yIE4wdWCSrPqVzCLEMIfLeVbBP7Ny8iFZU/FV NDjESJA+5yp7mVEDQlAmhlLcC0AvOqcyyks7p17H134Oy4Bex8ggIIZPVUANzTE/Zh5l 9NzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LRIXf2Yg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q20si483009edc.517.2020.09.29.05.43.22; Tue, 29 Sep 2020 05:43:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LRIXf2Yg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729484AbgI2LPD (ORCPT + 99 others); Tue, 29 Sep 2020 07:15:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:58926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729477AbgI2LO4 (ORCPT ); Tue, 29 Sep 2020 07:14:56 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36AC620848; Tue, 29 Sep 2020 11:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601378095; bh=oqfgm3QiMflCw7HWafNqLL+eZ5LDEC54GAEMgL79QS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LRIXf2YgPANAPibCFMAF1PDzrotvJIQdeqQskMHTiB95eqxbh7Nm2JmF25+JYn36o qYZC83/7U2JuC2QN8oaEATst3tScpXuxYsXKe8gaeb3JFwdV4VjEoeWT8kAwKgs68F jnSoYKro9xtLhVVn3TYMFTnJHwJjqlulp0umIA0k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Satish Kharat , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 029/166] scsi: fnic: fix use after free Date: Tue, 29 Sep 2020 12:59:01 +0200 Message-Id: <20200929105936.661936933@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105935.184737111@linuxfoundation.org> References: <20200929105935.184737111@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit ec990306f77fd4c58c3b27cc3b3c53032d6e6670 ] The memory chunk io_req is released by mempool_free. Accessing io_req->start_time will result in a use after free bug. The variable start_time is a backup of the timestamp. So, use start_time here to avoid use after free. Link: https://lore.kernel.org/r/1572881182-37664-1-git-send-email-bianpan2016@163.com Signed-off-by: Pan Bian Reviewed-by: Satish Kharat Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/fnic/fnic_scsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index d79ac0b24f5af..04c25ca2be45f 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -1034,7 +1034,8 @@ static void fnic_fcpio_icmnd_cmpl_handler(struct fnic *fnic, atomic64_inc(&fnic_stats->io_stats.io_completions); - io_duration_time = jiffies_to_msecs(jiffies) - jiffies_to_msecs(io_req->start_time); + io_duration_time = jiffies_to_msecs(jiffies) - + jiffies_to_msecs(start_time); if(io_duration_time <= 10) atomic64_inc(&fnic_stats->io_stats.io_btw_0_to_10_msec); -- 2.25.1