Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3760781pxk; Tue, 29 Sep 2020 05:44:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX0y3eQo4ByHyrT7m9gFkNv5uD5wVlC3IpPTogVXV5/W6tTOVG3UzBJX1FMDqaN5itNn5f X-Received: by 2002:a17:906:244f:: with SMTP id a15mr907441ejb.108.1601383494082; Tue, 29 Sep 2020 05:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601383494; cv=none; d=google.com; s=arc-20160816; b=JcE6Ib5LATvWcSxPRdeCMSIBxO0E3xSqPijcKpQelxRJIjHFXr6TxBog0fq7DlZLUw Fu+YrVX/NlelL9MG+U8Xqt3cOywapTuGDrgG1SZlhbZ3Lm+JsonPxXYo0GpyID4exTw6 /4xo3D1mN6dARLiMQ8O/lAd/5T8Gslcgo9/ExPEmsC4ISX7JDhFJ4xCN4YZUZUlaywnP EbRIV8sFyZjhU3WNhXCuyaSyjVFG8x5Km42FIf7xHiTCK2MGGtKKPiJYSFQrKiVbLi4q +JT0FpU45LqvWUSDr0MQP2vGvZnxaPAFoToXJlP6/GWBz5i9+HpsfSaImWixmKBytSrS bgqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=e8sWd2mAsHYZ8CmdmyHBMK8ia2JNWgquJkmPDxR942Y=; b=KGibEl69L8t5BCV1hJB3Fy6E0Z1z+e6P48lqtUov/hdUc5VjuEF1I1DHpEc3Dt701M 84daCXaAs06ugNrgkuq5wWaz9dzAPUJqqqraA10z8DVnoL99s+U6SLPCjtk1a7BOiLiK BvAcWRu83fUnoBTxDHFBjgwQaltxhiMUt3R9lwQz9PoKTGT+d9biBK01+/h9Rv9UeJvr eEHNoEEThcnQn+bAwuUGo+xCl7RaHbDGSVKQFmpeWTHWqdHbQgZx2WLodWmrBgL/+obv EY84zXfKnvS+bX0AUvFugjumCnecOhvWfjJbNUcGPdmiQiU2f3FvFNrV+hfZ4SMSgzeS 8XRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MpLyS6Vf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r2si2680827edc.25.2020.09.29.05.44.31; Tue, 29 Sep 2020 05:44:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MpLyS6Vf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387431AbgI2MmN (ORCPT + 99 others); Tue, 29 Sep 2020 08:42:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:53384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728729AbgI2LLx (ORCPT ); Tue, 29 Sep 2020 07:11:53 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84ADD2158C; Tue, 29 Sep 2020 11:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601377913; bh=hW6fRqiJnoP0f/soN1MX0TjBN2a7bTw19nIOCeIaSt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MpLyS6VfKOcbBtG2yS8uYmsUxe7FAnkvZqGb7w2ce/rivZHlit8zpeIrBy1qlsca9 CL22EcKECZIIeNbBMssuKFDB6Ogt1refeJM0fRyFL1TzDh6V4jd2QCqMB/H8p9BX/G oypk2Ez12Ddx7WXdRPCQFZJHGSYEUh0puWR3JiD8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthew Wilcox , Miklos Szeredi , Sasha Levin Subject: [PATCH 4.9 087/121] fuse: dont check refcount after stealing page Date: Tue, 29 Sep 2020 13:00:31 +0200 Message-Id: <20200929105934.488374850@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105930.172747117@linuxfoundation.org> References: <20200929105930.172747117@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi [ Upstream commit 32f98877c57bee6bc27f443a96f49678a2cd6a50 ] page_count() is unstable. Unless there has been an RCU grace period between when the page was removed from the page cache and now, a speculative reference may exist from the page cache. Reported-by: Matthew Wilcox Signed-off-by: Miklos Szeredi Signed-off-by: Sasha Levin --- fs/fuse/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index b99225e117120..f0129c033bd66 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -825,7 +825,6 @@ static int fuse_check_page(struct page *page) { if (page_mapcount(page) || page->mapping != NULL || - page_count(page) != 1 || (page->flags & PAGE_FLAGS_CHECK_AT_PREP & ~(1 << PG_locked | 1 << PG_referenced | -- 2.25.1