Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3761938pxk; Tue, 29 Sep 2020 05:46:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBTp2gnHzec4LWsJOwE+HvaL+F1IRIWeMVhxeSGu0B9o+TFquSR+3/XF8AD6A+nGt5Zcw4 X-Received: by 2002:a17:906:c0c4:: with SMTP id bn4mr3621040ejb.27.1601383599015; Tue, 29 Sep 2020 05:46:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601383599; cv=none; d=google.com; s=arc-20160816; b=PrUqRCrX1PXN1/ro1zyW88ErLkFRocXX91xsdQvXUe+jqXBECakYyxYflOOVHltow4 s3dpt4YO4sldHOSllcjv4PDC6ZfEh/ttHMmdYHCOK8VgpId4aL/libskv/JcFBoxZ2CC 2YLYKxstrzp3X2isBCQZxI0TL1B0lR/pC/X+bbsgX/msE80plW+fJ12VcS99/RyVIAUi 5O8wVP4L6tOhJfyFrNK239+C6h8DNWSmqMgDWX6sOpNj315kZg1oRmaH4O+Cd3U1qYu+ Q0f1ks63fW5dnALz1vyZ82TGSSEqzUGILt8wC8Z85KCmtsMIYUdLky+fodCj/Cuu3/O9 SQDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2VV9SOGTLOI7cfDMEEPxclBdlWhIrzsCwhwp72XPeto=; b=Fz6o1C49TsDhjrNpXHPiIMUbnqoozkCWrOZ2Yx61OxqLTycNmrlzsMDQ86IXoyKH7Y qf4wr5v67hugqWbSBZTCZV++Y61Igl8S+Yif37hBOotC5u8LN9L2k6kr2B9c47Gmt8Rw uNc8kemGwVv9UDlVlWfECi92NWQi7haAF3vV2mO7SylJQd/LCIbRiesc0DLRwsqKs57R gFsjYr7HNZmbl6wVgpfuXukGH1EvFLfBlDUkI43QWnKdaMZQq0r345bsK3vcQR4qGaMN uwX3obEDSkE1Fp5AI6/9sy4nkqg2J45x8F7pXkH23zpEi09TO/0iUHvILQBNUj7sGiVr hKpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w4cvDx/4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu11si2874092ejb.657.2020.09.29.05.46.16; Tue, 29 Sep 2020 05:46:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w4cvDx/4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732771AbgI2Mo4 (ORCPT + 99 others); Tue, 29 Sep 2020 08:44:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:47392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728691AbgI2LIY (ORCPT ); Tue, 29 Sep 2020 07:08:24 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19D3221D92; Tue, 29 Sep 2020 11:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601377677; bh=1QMLin64MVWTNPN6qqj3EmmEWt0wEi4HzuuQKU7Nb3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w4cvDx/4EKVFZ42c2/TrWD/mJXhzurfnqNoHq+FGaEOxWRoXYJXWtEyLWnkt/3jEm STID2JoBxBCHxv7g3LqzyfjLxpbGv/ziTKumZK65ckJezniy7FLahgPMDrWpNBny6f PIXR4jZ1Mr+yzhlJo+FM1Wkuc8NZ2ewW76txMCXk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 032/121] rt_cpu_seq_next should increase position index Date: Tue, 29 Sep 2020 12:59:36 +0200 Message-Id: <20200929105931.771885095@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105930.172747117@linuxfoundation.org> References: <20200929105930.172747117@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit a3ea86739f1bc7e121d921842f0f4a8ab1af94d9 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index c8c51bd2d695b..e9aae4686536a 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -271,6 +271,7 @@ static void *rt_cpu_seq_next(struct seq_file *seq, void *v, loff_t *pos) *pos = cpu+1; return &per_cpu(rt_cache_stat, cpu); } + (*pos)++; return NULL; } -- 2.25.1