Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 devicetree 1/2] powerpc: dts: t1040: add bindings for
 Seville Ethernet switch
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, robh+dt@kernel.org,
        shawnguo@kernel.org, mpe@ellerman.id.au, devicetree@vger.kernel.org
Cc:     benh@kernel.crashing.org, paulus@samba.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, madalin.bucur@oss.nxp.com,
        radu-andrei.bulie@nxp.com
References: <20200929113209.3767787-1-vladimir.oltean@nxp.com>
 <20200929113209.3767787-2-vladimir.oltean@nxp.com>
From:   Maxim Kochetkov <fido_max@inbox.ru>
Message-ID: <adfab73d-4073-2f9d-0bad-054ccb4b2534@inbox.ru>
Date:   Tue, 29 Sep 2020 16:12:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <20200929113209.3767787-2-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>


29.09.2020 14:32, Vladimir Oltean пишет:
> Add the description of the embedded L2 switch inside the SoC dtsi file
> for NXP T1040.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> Changes in v2:
> Make switch node disabled by default.
> 
>   arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 76 +++++++++++++++++++++
>   1 file changed, 76 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> index 315d0557eefc..5cb90c66cd3f 100644
> --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> @@ -628,6 +628,82 @@ mdio@fd000 {
>   			status = "disabled";
>   		};
>   	};
> +
> +	seville_switch: ethernet-switch@800000 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "mscc,vsc9953-switch";
> +		reg = <0x800000 0x290000>;
> +		little-endian;
> +		status = "disabled";
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			seville_port0: port@0 {
> +				reg = <0>;
> +				status = "disabled";
> +			};
> +
> +			seville_port1: port@1 {
> +				reg = <1>;
> +				status = "disabled";
> +			};
> +
> +			seville_port2: port@2 {
> +				reg = <2>;
> +				status = "disabled";
> +			};
> +
> +			seville_port3: port@3 {
> +				reg = <3>;
> +				status = "disabled";
> +			};
> +
> +			seville_port4: port@4 {
> +				reg = <4>;
> +				status = "disabled";
> +			};
> +
> +			seville_port5: port@5 {
> +				reg = <5>;
> +				status = "disabled";
> +			};
> +
> +			seville_port6: port@6 {
> +				reg = <6>;
> +				status = "disabled";
> +			};
> +
> +			seville_port7: port@7 {
> +				reg = <7>;
> +				status = "disabled";
> +			};
> +
> +			seville_port8: port@8 {
> +				reg = <8>;
> +				phy-mode = "internal";
> +				status = "disabled";
> +
> +				fixed-link {
> +					speed = <2500>;
> +					full-duplex;
> +				};
> +			};
> +
> +			seville_port9: port@9 {
> +				reg = <9>;
> +				phy-mode = "internal";
> +				status = "disabled";
> +
> +				fixed-link {
> +					speed = <2500>;
> +					full-duplex;
> +				};
> +			};
> +		};
> +	};
>   };
>   
>   &qe {
>