Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3795265pxk; Tue, 29 Sep 2020 06:32:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwSlixjdLmDE44EsK0MXuTobcg672DOE46tFvCjaTZVAGY49KIcdBeM+YV03g4s7pC/IS3 X-Received: by 2002:a05:6402:3c8:: with SMTP id t8mr3181655edw.266.1601386370688; Tue, 29 Sep 2020 06:32:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601386370; cv=none; d=google.com; s=arc-20160816; b=OGZzzoZorysB9TFjdHfv6k86/YWM900aa6DVWW2+FxPh1yVFBB35ki/URWQ3d8cgxk a/lbn40we1uefg4ljmN4hqZmm4sj59d/jWGqdUbBGbI8OKkgp+k1jB6kup/7O4yotegc cOuxQY49ncspnATam73I/eLq28B6QCNZXieQgvLrYPaF85OYCJuHS7cRauUQY4sDa/Tt 1sRKj+k+3q2OcCms1bozJPxVgao+26jt+XbkOFLLcEcWGHGLdWlkrsHhBsYh6zvQ1Y33 VKzDY3cTtWiiBBhllq6nXxJTUyjr+qYkxakwovXaErqgr0JbnZTFFPBAhjyHZlgrXCR+ 7KzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :autocrypt:from:references:cc:to:subject:dkim-signature; bh=Jen+vsBTJmwNeJb6XLUSNHPzK02PCNuLWQ2L4D6slPY=; b=cP3vVo7eYPSWT/xrIWU6EE1fpscXtsJWyza2kNFNfO63zqqq0RzfWTiEX89EaCDuoY Y+aQqLswNceFDl+2pF5ZTzHaFGIQuTdwqjtLVk/zir+K6V9PjL26M+pGBtjzCkFNoCMV L/uJwTgZqB52hS9z44yronqvOWkO97p1ude8pF5Y6Cez+GAjQhAVBQf9qh/RzSTxXG72 218iV5boCY7FKWfLCIqzRAHUI3CX8DSI1WV7Z6BY8iFmmuOaZpePWI9Jtm/yDVzmcseZ U1goFUqyD/gL4AzmFqSMME74HNLClGJruND+n+ggxH4Ot6clVevIv3c4Vi/op0saHFaq T+3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e5SUxbWA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l13si2545435ejc.723.2020.09.29.06.32.27; Tue, 29 Sep 2020 06:32:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e5SUxbWA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729863AbgI2NaN (ORCPT + 99 others); Tue, 29 Sep 2020 09:30:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44665 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728675AbgI2NaL (ORCPT ); Tue, 29 Sep 2020 09:30:11 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601386210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Jen+vsBTJmwNeJb6XLUSNHPzK02PCNuLWQ2L4D6slPY=; b=e5SUxbWAhjVIlYU9oRbFA/6AeA4INYKxfNSb3xtL8eVoMWs7jtFxLJV3kIpfg+eG/uLkB1 DmyeLwGqU6KXL0Ot3Ag1W+R+cunSDWWCT8ewv3p3+rFlb+sv+zZ3ACxjieuJauy3J0wUoI pOmUQSJW0LG9YiBubvT4JOT6BZtgJvM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359--XiroSRQOTW_NfsTbVWhWg-1; Tue, 29 Sep 2020 09:30:05 -0400 X-MC-Unique: -XiroSRQOTW_NfsTbVWhWg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A4768015C5; Tue, 29 Sep 2020 13:30:03 +0000 (UTC) Received: from [10.36.112.157] (ovpn-112-157.ams2.redhat.com [10.36.112.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id C5E0E5C1C4; Tue, 29 Sep 2020 13:30:00 +0000 (UTC) Subject: Re: [PATCH] mm: clarify usage of GFP_ATOMIC in !preemptible contexts To: Michal Hocko , Andrew Morton Cc: LKML , linux-mm@kvack.org, "Paul E. McKenney" , "Uladzislau Rezki (Sony)" , Thomas Gleixner , Michal Hocko References: <20200929123010.5137-1-mhocko@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63W5Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAjwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat GmbH Message-ID: <746c1b7d-f082-8f15-e3ae-c1f09344789f@redhat.com> Date: Tue, 29 Sep 2020 15:29:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200929123010.5137-1-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.09.20 14:30, Michal Hocko wrote: > From: Michal Hocko > > There is a general understanding that GFP_ATOMIC/GFP_NOWAIT are > to be used from atomic contexts. E.g. from within a spin lock or from > the IRQ context. This is correct but there are some atomic contexts > where the above doesn't hold. One of them would be an NMI context. > Page allocator has never supported that and the general fear of this > context didn't let anybody to actually even try to use the allocator > there. Good, but let's be more specific about that. > > Another such a context, and that is where people seem to be more daring, > is raw_spin_lock. Mostly because it simply resembles regular spin lock > which is supported by the allocator and there is not any implementation > difference with !RT kernels in the first place. Be explicit that such > a context is not supported by the allocator. The underlying reason is > that zone->lock would have to become raw_spin_lock as well and that has > turned out to be a problem for RT > (http://lkml.kernel.org/r/87mu305c1w.fsf@nanos.tec.linutronix.de). Interesting Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb