Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200919053145.7564-1-post@lespocky.de> <20200919053145.7564-4-post@lespocky.de>
 <20200922155747.GA2734659@bogus> <23920329.U7EUVLB22C@ada>
In-Reply-To: <23920329.U7EUVLB22C@ada>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 29 Sep 2020 08:58:13 -0500
Message-ID: <CAL_JsqKYWC82OB9OVtwsBnKHpfDfRYATdYfGXc0hiQ2kAgoKJg@mail.gmail.com>
Subject: Re: [PATCH v5 3/3] dt-bindings: leds: Convert pwm to yaml
To:     Alexander Dahl <ada@thorsis.com>
Cc:     Alexander Dahl <post@lespocky.de>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree@vger.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        =?UTF-8?B?TWFyZWsgQmVow7pu?= <marek.behun@nic.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 29, 2020 at 2:39 AM Alexander Dahl <ada@thorsis.com> wrote:
>
> Hei hei,
>
> Am Dienstag, 22. September 2020, 17:57:47 CEST schrieb Rob Herring:
> > Use generic node names:
> >
> > led-controller {
> >
> > > +        compatible =3D "pwm-leds";
> > > +
> > > +        led-1 {
> > > +            label =3D "omap4::keypad";
> > > +            pwms =3D <&twl_pwm 0 7812500>;
> > > +            max-brightness =3D <127>;
> > > +        };
> > > +
> > > +        led-2 {
> > > +            color =3D <LED_COLOR_ID_GREEN>;
> > > +            function =3D LED_FUNCTION_CHARGING;
> > > +            pwms =3D <&twl_pwmled 0 7812500>;
> > > +            max-brightness =3D <255>;
> > > +        };
> > > +    };
> > > +
> > > +...
>
> This is clear for the "one led-controller" case.  However, when trying to=
 fix
> those node names in existing .dts files, I wondered how those should be n=
amed
> for multiple, different led-controllers, e.g. one using "pwm-leds" and an=
other
> one using "gpio-leds"?
>
> See arch/arm/boot/dts/at91-kizbox3-hs.dts for example, the nodes are call=
ed
> "pwm_leds" and "leds" currently.  If both were part of a .dtsi and both n=
amed
> the same, you could not overwrite/complement those in a .dts file includi=
ng
> that .dtsi due to a name conflict.
>
> Just append a numerical index like this?
>
>   led-controller-1 {
>     =E2=80=A6
>   };
>
>   led-controller-2 {
>     =E2=80=A6
>   };

Yes, that's generally what we've been doing.

Rob