Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: vRDWGH6FOVcYL5eSl+8FzHWbSGlUb5ZOiiLgWdt1GNZlJ+4R+iLln+eTQDY6SWhDAwNIZVhavZ
 7OaSzg3ZGe3w==
IronPort-SDR: +wZ7CksQQGgpYoSu7T9vjla7Z7LXHP4nUC66KD+iy+ZE+tDTtX+LPy1y98ZBdBUPec+1xZycL9
 aYqZuQ+jA89A==
From:   "Rojewski, Cezary" <cezary.rojewski@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] list: Add a macro to test if entry is pointing to the
 head
Thread-Topic: [PATCH v2] list: Add a macro to test if entry is pointing to the
 head
Thread-Index: AQHWlmaO97X0AF+CMUuhSjA0mQ6lcal/rq5g
Date:   Tue, 29 Sep 2020 14:40:23 +0000
Message-ID: <5f95bede9603416ca9f1c6ee17d54b35@intel.com>
References: <20200929134342.51489-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20200929134342.51489-1-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

On 2020-09-29 3:43 PM, Andy Shevchenko wrote:
> Add a macro to test if entry is pointing to the head of the list
> which is useful in cases like:
> 
>    list_for_each_entry(pos, &head, member) {
>      if (cond)
>        break;
>    }
>    if (list_entry_is_head(pos, &head, member))
>      return -ERRNO;
> 
> that allows to avoid additional variable to be added to track if loop
> has not been stopped in the middle.
> 
> While here, convert list_for_each_entry*() family of macros to use a new one.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: converted users inside list.h, dropped ambiguous description

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

This is a good addition to the list of helper macros found in list.h.

When looking at below:

>   /**
>    * list_for_each_entry	-	iterate over list of given type
>    * @pos:	the type * to use as a loop cursor.
> @@ -617,7 +626,7 @@ static inline void list_splice_tail_init(struct list_head *list,
>    */
>   #define list_for_each_entry(pos, head, member)				\
>   	for (pos = list_first_entry(head, typeof(*pos), member);	\
> -	     &pos->member != (head);					\
> +	     !list_entry_is_head(pos, head, member);			\
>   	     pos = list_next_entry(pos, member))
>   

it seems such helper should have been here a long time ago (notice the
usage of helpers for initial assignment and cursor update while the
loop-exit check was devoid of such).

Czarek