Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3876583pxk; Tue, 29 Sep 2020 08:23:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZ7cf+MSy1ufB3SB22wzh9mWTtcUR9i8zOWCGWTwmItRnBB8hSlFE8HpLREOw+fOjwtElK X-Received: by 2002:aa7:c3c8:: with SMTP id l8mr3980024edr.368.1601392981223; Tue, 29 Sep 2020 08:23:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601392981; cv=none; d=google.com; s=arc-20160816; b=OEHmT8i2OPOoWLbKYMDGAxp2deQZb0kEDr5bF5cYIx229U5Z9gKVJXV5BbElGkwOBI jRzGLDaSCxsfEjme2387dukBIvQF9BauxiYtPRHTkua+FreC+h2Oo1GC1wIh6JeFbPFd 4c+cYSTr20Gnv7xGGIUO3tAbxXmqIoHjaZrdX3PGEpVgjin8DoH54LnL0WhV8TV6Z+sm CuMNTl3bEnE3GGqipgT/6bUzvB3nAzEc/rGOA8CV5dTfGzqTw7bzaILYqwpi40Rrgji5 Blx7h7QjDPxiwfKVxNWMTTlWe8JIt3jYVBSrg8TLGLJdWiXFOf+3VCAsAQWdINjKd81D Tc5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=J5eBvMphy7yOQzn65/9G/Lz0q6Ayk2IZC3U4Ey+fZwk=; b=hz7Jcw0Nv6RrMTCQRDtTg4hxvEX5UqMNCOt1xJeosovRiGOdStLuFLSRHiuiNJQQE3 /G18iwJWMqP3OR9J9wn/mLQHU7h316Z1GZLCk3yLlMJh5VoY3mt63BAt0ox7xweCdvNj pykr7ZFYBhOjOt5gs2N5FHipwc9oZStSGcJp1TTJHdgEYP0WnwycBKe36GnZAuS5kPNs wn2pKMWHAA5MIUEU30nfcGdZYPW8tZwrIavOsdXR7l8k04WvX0A2FHt1D9Jow9GRuJlU ihAgK0RmtS9ADIrOM3+5DKluyLTol/LAgfntAcIpuUihiwwrZomIJxPFusqxt+P7kbNH QIQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si2954656ejk.674.2020.09.29.08.22.36; Tue, 29 Sep 2020 08:23:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728375AbgI2PTH (ORCPT + 99 others); Tue, 29 Sep 2020 11:19:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbgI2PTG (ORCPT ); Tue, 29 Sep 2020 11:19:06 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69586207C4; Tue, 29 Sep 2020 15:19:05 +0000 (UTC) Date: Tue, 29 Sep 2020 11:19:03 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Paul McKenney , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , kim.phillips@amd.com Subject: Re: [PATCH] rcu,ftrace: Fix ftrace recursion Message-ID: <20200929111903.3e3e8c23@gandalf.local.home> In-Reply-To: <20200929144953.GP2628@hirez.programming.kicks-ass.net> References: <20200929113340.GN2628@hirez.programming.kicks-ass.net> <20200929103620.06762622@gandalf.local.home> <20200929144953.GP2628@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2020 16:49:53 +0200 Peter Zijlstra wrote: > On Tue, Sep 29, 2020 at 10:36:20AM -0400, Steven Rostedt wrote: > > > > +notrace bool rcu_is_watching(void) > > > { > > > bool ret; > > > > > > > I think the patch I suggested is more suitable. > > Both, with only your patch we'd still take the pointless mcount call, > which is then pure overhead. Yep, and I stated the same thing to Paul ;-) -- Steve