Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Sep 2020 10:23:40 -0700
From:   Martin KaFai Lau <kafai@fb.com>
To:     Lorenz Bauer <lmb@cloudflare.com>
CC:     Shuah Khan <shuah@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        kernel-team <kernel-team@cloudflare.com>,
        <linux-kselftest@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 4/4] selftest: bpf: Test copying a sockmap
 and sockhash
Message-ID: <20200929172340.hogj6zficvhkpibx@kafai-mbp.dhcp.thefacebook.com>
References: <20200928090805.23343-1-lmb@cloudflare.com>
 <20200928090805.23343-5-lmb@cloudflare.com>
 <20200929060619.psnobg3cz3zbfx6u@kafai-mbp>
 <CACAyw9-hSfaxfHHMaVMVqBU7MHLoqgPyo55UwQ3w7NKREHcCxw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACAyw9-hSfaxfHHMaVMVqBU7MHLoqgPyo55UwQ3w7NKREHcCxw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kafai-mbp.dhcp.thefacebook.com (2620:10d:c090:400::5:f2d3) by MWHPR10CA0020.namprd10.prod.outlook.com (2603:10b6:301::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Tue, 29 Sep 2020 17:23:46 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 16af6e4b-bf25-4724-7cdd-08d8649c6cb2
X-MS-TrafficTypeDiagnostic: BYAPR15MB2725:
X-Microsoft-Antispam-PRVS: <BYAPR15MB27255B1B9F5DFA9B01F08A22D5320@BYAPR15MB2725.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Hq+gyuyMlphFJFAj/35IsFtF+IU0fL6ivst+Fc0054Fzwu6YyDrUJdPB72FpH1+1jV1tTxO1b41UvhJNqLhAxiumK9dszHl3GkogPa4Xh+b0bRKTnsNRKu8AgYUTOTkZhauhQWg7nirNNXeB+X9opYg1onArbtbAybJ67LVBliUHnb5NUdNNlUTgs2+3lJ5HceWAhaGUXsVVNcn/oD/FpsVcIt5iH+Ysr8wZfD1v6enl6zsi97Pf3zv1M4TlvG+I1L5jzNh/0ceuBO6ja8mARBOJ7p+7/HSpernQVAXOWqcUnKKA67M+6Ng11P1mbXbnqx7G4A+zM9Glk586q14UzddTQX+/ERh76ATE4SYFshTfv7AfMLRosruf9rgeUYF9
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR15MB3571.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(346002)(366004)(136003)(376002)(83380400001)(478600001)(4326008)(8676002)(186003)(52116002)(7696005)(2906002)(54906003)(316002)(16526019)(66476007)(6506007)(66556008)(8936002)(55016002)(6916009)(5660300002)(9686003)(1076003)(86362001)(66946007)(4744005)(6666004);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: J9rmFVVnbQ/37zqLcCK0sVgBAfWUGEImh03NqZScluAq5m8S6xWSb0KQyftlCmemwWJJ7cjqu9v7ugJNBvsACh8/aQCy47xB5KN8YJpY92/rJYxYjFdyda7N1AU+gVVUCQQFCsb1hZCjbIBMmmZiLE1LVQHJ/zibxsSQ5W4ReT1q/1mZPj85UL07H4mxD1Mh4rX8b07sXp7sTz0s1z/yQ1uTDa271auY0OC42v/FLnb/AGu92vVqoNUgzJs7TVkQJes8pvBh3wcJDANmZ5LVhJTpYkFq+H2fj/u866NC9g5VIQNK7/6udIAUiR3tpP0bwmZtIib9ic8LgtyTPfEzaqbWclH5kcPMtYFev9A2WZY0VaHbF9fxIEN0N7Oi5ajcqyMuu6kVVcMz7E9mBdSWawCvjs7svx7lvgfwyUsybuRee/MsnGi+g6wPpJT+v/tFM8w7t/5U3XE0ptZtrOyAwT0X7jQt8Q+rZl+HIvxus1QnqGngE6HSBVHJRHEL3fDq+rysVMtCq7u9VvGOT0sKKxKYG0TXF6U/AV/1nt+jn+vmKrelbyGvCUI69HGPoNliDWlFZkshvTwQYyhMaW3AyG58nqacZMpmIaxTYbL7YpzGd4xsqU0Mc8nq9vY78cgJXgvxwMyCWU68ti7UFNr35RvdRu4LgQptVUgleCZhOaM=
X-MS-Exchange-CrossTenant-Network-Message-Id: 16af6e4b-bf25-4724-7cdd-08d8649c6cb2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3571.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2020 17:23:47.8245
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0OA87K0JFaIt6ZZg9bCCCiLe9hlX8Ura6HNHTh37F+FcE3D9ZEtoL1HgXb61/gsk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2725
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-09-29_11:2020-09-29,2020-09-29 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 lowpriorityscore=0 mlxlogscore=969 priorityscore=1501 phishscore=0
 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0 clxscore=1015
 impostorscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2006250000 definitions=main-2009290147
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 29, 2020 at 10:21:05AM +0100, Lorenz Bauer wrote:
> On Tue, 29 Sep 2020 at 07:06, Martin KaFai Lau <kafai@fb.com> wrote:
> 
> ...
> 
> > > +     /* We need a temporary buffer on the stack, since the verifier doesn't
> > > +      * let us use the pointer from the context as an argument to the helper.
> > Is it something that can be improved later?
> >
> > others LGTM.
> 
> Yeah, I think so. We'd need to do something similar to your
> sock_common work for PTR_TO_RDONLY_BUF_OR_NULL. The fact that the
> pointer is read only makes it a bit more difficult I think. After
I thought the key arg should be used as read-only in the map's helper.
or there is map type's helper that modifies the key?

> that, a user could just plug the key into map_update_elem directly.
> Alternatively, allow specialising map_ops per context.