Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Sep 2020 12:56:32 -0500
From:   Rob Herring <robh@kernel.org>
To:     Vadym Kochan <vadym.kochan@plvision.eu>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: nvmem: add description for ONIE provider
Message-ID: <20200929175632.GA860453@bogus>
References: <20200921235237.7980-1-vadym.kochan@plvision.eu>
 <20200921235237.7980-3-vadym.kochan@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200921235237.7980-3-vadym.kochan@plvision.eu>
Precedence: bulk

On Tue, Sep 22, 2020 at 02:52:37AM +0300, Vadym Kochan wrote:
> Add device-tree binding description for the ONIE nvmem provider.

What's ONIE?

> 
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> ---
>  .../devicetree/bindings/nvmem/onie-nvmem.txt          | 11 +++++++++++

Bindings are in schema format now.

>  1 file changed, 11 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/nvmem/onie-nvmem.txt
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/onie-nvmem.txt b/Documentation/devicetree/bindings/nvmem/onie-nvmem.txt
> new file mode 100644
> index 000000000000..16fb903118d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/onie-nvmem.txt
> @@ -0,0 +1,11 @@
> += Device tree bindings for ONIE NVMEM provider =
> +
> +Required properties:
> +- compatible: should be "onie-nvmem"
> +- nvmem: phandle to nvmem device node

Not a standard property.

I don't understand what you are trying to do.

> +
> +Example:
> +	onie_cells {
> +		compatible = "onie-nvmem"
> +		nvmem = <&at24>;
> +	};
> -- 
> 2.17.1
>