Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4020336pxk; Tue, 29 Sep 2020 12:03:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeOi4G68hROFCnx+45sG522ibVxKyCQv4TT+hkEiwwmqePM9/nYK8lp6Scslj4Ib/DIsar X-Received: by 2002:a05:6402:b9a:: with SMTP id cf26mr4704327edb.375.1601406184205; Tue, 29 Sep 2020 12:03:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601406184; cv=none; d=google.com; s=arc-20160816; b=gxCnEaSr+AUo0zfI8bZ/USS+sddU1p/VPoVjEouw6WzBr0eiAsAOB+1vjKR1NPR9p5 L1S9+jQ7pfmqcJi+IHaY4mkVhChRsYbnRmBFaXiWEaDeh7s7H0VrL89RWyRPnN5qAyy+ 4eKVANfQH1mp7PXhtkSnIWolPt2b/PlEKugwYLyn1ik0AWdWCTh128Lz7g36MeWtlYem xdNkrozJDZ3nVmu9MDicvHKd6WyNen5uRvFcZWPhB/60YMYsgwDZ+8IQ++yPNTiNXQ/Y y/vk/x2FOv9hmfbbqLa5Sx2dwUC7F0aimClUUUtuom3yVR9ldioGPGxyooL2jSy/ZRsq mh1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=DnmTNplotRRR/qxw4AWftTeBjRlYNWMKBBfAgIjGMJM=; b=g4OQ4eZo+A8JgDdWvOSLcnP09FnqBHEo9Uo2KoebzCiq50MVSG7efy8EaXNDTlyZ9h 1UwRPJ3tXNY3giQv3PIyjtP3Pd1AdJeAN+C2XIK0yNP0zIZcU798ny7RYPa14iBolC+l e4+smqK2bekFulfVwQ6p8qv7goIxta7uOjZmMH0VLM4oPlTzzs0fuc8kNJM3wgAOhOC1 VAs/qIzueSTylNZ8+5jalmg6IGAFc1v3PfYJ8LmQgW5hJHOLxGrIgnlW7AtOvdudgVuI TkdXIBc9Njw97pGmcbqJXhZUF/oSLYzEre9l8JU25NuPg3/vSvsBYW729xq+I9+4jnuE HgJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=ayxqxoWr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a21si3342548eds.368.2020.09.29.12.02.40; Tue, 29 Sep 2020 12:03:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=ayxqxoWr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728540AbgI2S75 (ORCPT + 99 others); Tue, 29 Sep 2020 14:59:57 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:13455 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728172AbgI2S75 (ORCPT ); Tue, 29 Sep 2020 14:59:57 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 29 Sep 2020 11:58:15 -0700 Received: from [10.2.53.30] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 29 Sep 2020 18:59:56 +0000 Subject: Re: [PATCH 2/8] selftests/vm: use a common gup_test.h To: Jason Gunthorpe CC: Andrew Morton , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ralph Campbell , Shuah Khan , LKML , , , , References: <20200928062159.923212-1-jhubbard@nvidia.com> <20200928062159.923212-3-jhubbard@nvidia.com> <20200928125739.GP9916@ziepe.ca> <6481e78f-c70d-133a-ff4a-325b5cd8fd5d@nvidia.com> <20200929163507.GV9916@ziepe.ca> <20200929175524.GX9916@ziepe.ca> From: John Hubbard Message-ID: <715c49ec-d2a8-45cb-8ace-c6b1b4b8f978@nvidia.com> Date: Tue, 29 Sep 2020 11:59:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200929175524.GX9916@ziepe.ca> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601405895; bh=DnmTNplotRRR/qxw4AWftTeBjRlYNWMKBBfAgIjGMJM=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=ayxqxoWrh8CnUTzyfHWb9J4A5gPuRtiEduP2eFCYc38cvJTvbmnYbMndIFDpHd+F/ lA3vFdd4TyZ2V4QdwHIuQY3746GyhQkfmPuC72+KQ2agHmnfq1XjLcarkPcA+esGNk +zJxX87yMrBcXZ3NPFIVilBE2+uaQC/RjGtA44gPSBoXo5/fc+QkrXpVCDlO0UMfpV BLWyyZ+3o8fkKNMMAz+llCFL9pFhhLshyxzxsdQKPeIXPGgvuu5MaiWxs0s3G3Rnld 1cE+QIUrmDaGCu0q/LzmnT8CaKQjMITbruodKASFrF9T9Db5ChT6APdi21UtgS7cn6 bC7KgIIBIb79g== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/20 10:55 AM, Jason Gunthorpe wrote: > On Tue, Sep 29, 2020 at 10:44:31AM -0700, John Hubbard wrote: >> On 9/29/20 9:35 AM, Jason Gunthorpe wrote: >>> On Mon, Sep 28, 2020 at 01:10:24PM -0700, John Hubbard wrote: >>>> On 9/28/20 5:57 AM, Jason Gunthorpe wrote: >>>>> On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: ... >> I don't see any "gcc -m" type of dependency generation pass happening >> in this relatively simple Make system. > > It happens with -MD, all the deps are stored in files like mm/.init-mm.o.cmd > and sucked into the build. You are thinking of kbuild. This is not kbuild. There are no such artifacts being generated. >> And so, without including an explicit header file dependency (at >> least, that's the simplest way), changes to gup_test.h are not >> detected. > > Shouldn't be > >> Both the Makefile code and the observed behavior back this up. (I >> expect that this is because there is less use of header files in >> this area, because most unit tests are self-contained within a >> single .c file.) > > Something else is very wrong then. > Not really, it's just a less-cabable system than kbuild. thanks, -- John Hubbard NVIDIA