Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200929005320.14739-1-david.e.box@linux.intel.com>
 <20200929005320.14739-4-david.e.box@linux.intel.com> <d6d59aad-a946-d780-b2d2-9c187fd8303c@infradead.org>
In-Reply-To: <d6d59aad-a946-d780-b2d2-9c187fd8303c@infradead.org>
From:   Alexander Duyck <alexander.duyck@gmail.com>
Date:   Tue, 29 Sep 2020 12:12:27 -0700
Message-ID: <CAKgT0Uc9LtFKnaHpzJhBLyeB_ycD74mb8wcaaO4KZBn+05Je5w@mail.gmail.com>
Subject: Re: [PATCH V6 3/5] platform/x86: Intel PMT class driver
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     "David E. Box" <david.e.box@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>, dvhart@infradead.org,
        Andy Shevchenko <andy@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Alexander Duyck <alexander.h.duyck@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org,
        linux-pci <linux-pci@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 28, 2020 at 6:24 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 9/28/20 5:53 PM, David E. Box wrote:
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 40219bba6801..093c43b63f48 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1360,6 +1360,15 @@ config INTEL_PMC_CORE
> >               - LTR Ignore
> >               - MPHY/PLL gating status (Sunrisepoint PCH only)
> >
> > +config INTEL_PMT_CLASS
> > +     tristate "Intel Platform Monitoring Technology (PMT) Class driver"
> > +     help
> > +       The Intel Platform Monitoring Technology (PMT) class driver provides
> > +       the basic sysfs interface and file heirarchy uses by PMT devices.
>
>                                              hierarchy
> No "heir" involved.

Knowing me I probably had class inheritance on the mind at the time
when I was writing it up and it was just a thinko.. :-)

Thanks for the review feedback. I'll work with David to make sure we
address the formatting/spelling issues in this patch and the crashlog
patch.

- Alex