Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4045791pxk; Tue, 29 Sep 2020 12:48:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUNjmgPXhJXGG3XOr/noWwtIK5tVRFGn08SWeos0FZvtTNuXFauATYXItV4GklvR115H8s X-Received: by 2002:a17:906:586:: with SMTP id 6mr5776168ejn.315.1601408913637; Tue, 29 Sep 2020 12:48:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601408913; cv=none; d=google.com; s=arc-20160816; b=fj1HBZ5x2sqwH+ikKvoT85PP+0rIHJ+bmchKuerA4ukWpFYmAx1AWtQia+WPPtlHYK xAN22Tx9BaJGZm8is5xPgpGOyTlEBkF3fgPAFBQKIij3Cux+YEXtQMC7oGGLEBIx9Hlm RntE1uLNvUQDzQXkFJgB5jp6lMKc4kqD3YB/toGmkC92Gnm5W26UYlgD8sm+9s1fD3KH eR9j5lq3hPmutWH9T+PkNd9oWK1zqBUF+qkiUlP1F+BCHxBf5CbPHxNHEQKRMzHJPNml z2OhXZPlIae41XheTNJWNlEZqPMjHSsPWocgJnQsbvJbw6rh0yffTApwzqmQDDq7RGQb gs5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=jjEzi8lg/fixZ8RSJmRBsh7VZs4uZ4cmuyV6enGSxv4=; b=Zeuk4/Oc2wu3LT8R7rq1e/sYLNggayTHSz8r0hpEs0r2zNi69Z9sRoY/ds/zM7EclP bzr/w4yjOeSmyBKqNYyRh76YUWTkLYajX8f1WjcS+D5erJVSAhxw+OC6YItTpWji8T2G fBUE5+AaqjOu+ij/74TI2QQvt1QyS5xTCMaU8/ET11gbJqnmBGVY+fQNCUcNo8WBCkXE NQkJcGTt7hLOwdi3xknCxnHBaGaQ60nwo008TYr5nX7dewxNnYZ5U4xzEYW5iB3THWoO iWQgIzcGHLBY4NdW+KhBZqiuyGfKwyUXjiNcp2z2GMudRvMSoAFd5VhRlD+/td9Y8sVF CMbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Kpj8AilV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si3366942edv.598.2020.09.29.12.48.09; Tue, 29 Sep 2020 12:48:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Kpj8AilV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728817AbgI2Tqa (ORCPT + 99 others); Tue, 29 Sep 2020 15:46:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:43474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727700AbgI2Tqa (ORCPT ); Tue, 29 Sep 2020 15:46:30 -0400 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6A9C2083B; Tue, 29 Sep 2020 19:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601408790; bh=jjEzi8lg/fixZ8RSJmRBsh7VZs4uZ4cmuyV6enGSxv4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Kpj8AilVQM5xcmwB1Vb5LrYlzGb2bJ3ug0FO3i3lKqqT6+bQVh7OTRej29MV5LnRV psaTnlyAqXAIu8B02xUOFooNMugUfaHjJwE7dKKfCJFzGf7f6aln2133qYvfH/UIrW uYKbeYC+vvdFVf3B0Na3rUddE8UxIy8jMDLBlGNk= Received: by mail-ot1-f54.google.com with SMTP id m13so5643364otl.9; Tue, 29 Sep 2020 12:46:29 -0700 (PDT) X-Gm-Message-State: AOAM531UbWK847ffND11rL5wNQ6uTrCI7j5D3ljb4HBtlYZGHOJ3kfbR xhnFSqO5QOQVNjY8Vr37ipcgNrptxpi/uTUXww== X-Received: by 2002:a9d:6b0d:: with SMTP id g13mr3933936otp.129.1601408789102; Tue, 29 Sep 2020 12:46:29 -0700 (PDT) MIME-Version: 1.0 References: <20200926131157.14633-1-kholk11@gmail.com> <20200929191254.GA984478@bogus> In-Reply-To: From: Rob Herring Date: Tue, 29 Sep 2020 14:46:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] phy: qcom-qusb2: Add support for SDM630/660 To: Konrad Dybcio Cc: AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , marijns95@gmail.com, Martin Botka , DTML , linux-arm-msm , phone-devel@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 2:25 PM Konrad Dybcio wrote: > > >You should just pull this from the driver data. > > I reused 8996's phy_cfg so as to change one line and not repeat dozens > for what's essentially the same thing, so I don't think it's the > better option.. Okay, save it for the next person when the if statement grows. Rob