Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4064792pxk; Tue, 29 Sep 2020 13:21:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaYBHqSh6jxdr/dG7DrV2KsPHPnZ6t+eFjlsVT3FkoGTq46QNnQ6E68FoWFLO12Cvqssg2 X-Received: by 2002:a05:6402:292:: with SMTP id l18mr5382861edv.6.1601410908677; Tue, 29 Sep 2020 13:21:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601410908; cv=none; d=google.com; s=arc-20160816; b=b6hqb5djqCoUlHs7G/b4vnaKbrdU+UfLyhl0Th4YRKR0H/tIWZVWfJKdj/Hdtsgknc 8HIlyFftPjgcGce0T9o/MwK2FolWaqh8Rd83S9iqGX9sIvtXXI3jJ8W0Yw/kuNpdaSWC 0kyJFrKOWKmUYfLH3hIh3xMi8FZ5wh96xUqkMW0VAxr14mVycaouxP+ahdKvKNt+SeX6 jLIDkKII8ErZjs3H8qijRQVMjpNg99KC97kJ+llTDBHni39dDMRa5XX9F0sX8nBili01 V1Ky2ZYrUGvP1cHv3WixbcOot4NaDDFboIOI82OhYlY3zyOV+ibRheSgBYDZpaQ59Cvs Z5hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=wY55VXytWU5dCb+yWsv+Hifz95sQhPM0ZRLjoZrF/Ks=; b=BhIJJal5y5QKu6Zd/0cMv1dIWgBRCRAq2HYsiUtgQFnNl4dX2cVm5A37YoT04YF2Zs PDhrOlV252H5w0F0oLgI6Vj/xWQSn/eQJruuRZRlDhlzwdMgchcKUBb4U6Q4ZcO07ha/ Qn6Vc7F0ADclmOsUyrRUHUm984SIz9jNXva9ahYP9S32vA9ZfuALxdolsAvrlqt0/ap1 AhV9l5Aoa2Xy2oHOQ8C+ltIrvUx7gUtDmemEaafPiqDFz/4L1sv43Gty9foFtovA8+eq Vtvu2YcKEqDKiWr37qehjhucSA12bWDoPZS1X8t3l70jMimQ6S015l8He1Cej38DANu+ rlzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=BPLY8Xv4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lw21si3248746ejb.724.2020.09.29.13.21.25; Tue, 29 Sep 2020 13:21:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=BPLY8Xv4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728999AbgI2UUS (ORCPT + 99 others); Tue, 29 Sep 2020 16:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728367AbgI2UUR (ORCPT ); Tue, 29 Sep 2020 16:20:17 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AAAFC0613D2 for ; Tue, 29 Sep 2020 13:20:17 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id u126so6898693oif.13 for ; Tue, 29 Sep 2020 13:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wY55VXytWU5dCb+yWsv+Hifz95sQhPM0ZRLjoZrF/Ks=; b=BPLY8Xv4N6HnAC2bhuVuHqsZLkqCRc3/qbrl8KFAlCtq8Kx4wgRywyzRbbG4+67cnz 7MPFNhrMkC2n4w3iaRpN03wj667JrqGXdCmrbRnqmqQbtDSx0PAMYXaCLv3Cb5UGGdQv eBY42MTMnDfHkjUH2avoe0cnVozJtma7NQnuo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wY55VXytWU5dCb+yWsv+Hifz95sQhPM0ZRLjoZrF/Ks=; b=BbUacXQUiyUeeN5vrv1W6uWHTNo2+hZgwC58jSA/bZF4ttlznZo4PzIgT7nDPtsB3R P+D95PBdqHj+wC6aq5XdrZA8uKBywl+sCb6GXGAZnuDBYM/61XKHJyOMow27ia2QDjLM knih/Ky/pFGqWmC99W4fsHTDLDjhnactRUaKpiSVYLCfpIX71/9CcSdwaKvgc0AbjAgV fkAVsqR0Y5d08cvfSrYl4uWo+Wge26GrVMY5M3+LejC4U6yy9XoPNGofdzNxMjV3/K0G re70dcojOPyVlMajN6nBbl2YURdpuUTKpkROwkZEWyWvyv79dMfSgmYSSw0uxXRIR6jf Zy8A== X-Gm-Message-State: AOAM532Afq2Bxi4VYw5jNmRmn3CrCr4w1lUoYS8Yzygqnwi3SN2monBC gxT1AMYtfm69nzIMIIHrh2wTWg== X-Received: by 2002:aca:df84:: with SMTP id w126mr3834010oig.103.1601410816915; Tue, 29 Sep 2020 13:20:16 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 65sm1238278otj.75.2020.09.29.13.20.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 13:20:16 -0700 (PDT) Subject: Re: [PATCH 2/8] selftests/vm: use a common gup_test.h To: John Hubbard , Jason Gunthorpe Cc: Andrew Morton , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ralph Campbell , Shuah Khan , LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Shuah Khan References: <20200928062159.923212-1-jhubbard@nvidia.com> <20200928062159.923212-3-jhubbard@nvidia.com> <20200928125739.GP9916@ziepe.ca> <6481e78f-c70d-133a-ff4a-325b5cd8fd5d@nvidia.com> <20200929163507.GV9916@ziepe.ca> <20200929175524.GX9916@ziepe.ca> <715c49ec-d2a8-45cb-8ace-c6b1b4b8f978@nvidia.com> <20200929190816.GY9916@ziepe.ca> <3022912c-f11b-f564-3a8a-f516ca259a37@nvidia.com> <20200929195356.GZ9916@ziepe.ca> <64bb5ba7-77f7-2f09-44f0-29ee9329b183@linuxfoundation.org> <554699c6-cc01-4c3c-3ed5-26d22ac3bac0@nvidia.com> From: Shuah Khan Message-ID: <9372727e-1a79-913b-5391-e0c4a85bf5a7@linuxfoundation.org> Date: Tue, 29 Sep 2020 14:20:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <554699c6-cc01-4c3c-3ed5-26d22ac3bac0@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/20 2:11 PM, John Hubbard wrote: > On 9/29/20 1:00 PM, Shuah Khan wrote: >> On 9/29/20 1:53 PM, Jason Gunthorpe wrote: >>> I only remarked because I didn't know it wasn't using kbuild. I >>> thought it would have used the existing HOSTCC stuff, not sure why it >>> is special. >>> >>> The only investment that seems worthwhile would be to switch it to use >>> the normal kbuild stuff?? >>> >> >> I explored switching to kbuild at the kernel summit last year during >> my kselftest where are we talk. >> >> There was push back from several developers. We can definitely explore >> it as long as we can still support being able to build and run >> individual subsystem tests and doesn't break workflow for developers. >> > > Do you have a link or two for that? Especially about the pushback, and > conclusions reached, if any. > Unfortunately no. A I recall it was workflow related issues and ease of running individual subsystem tests and backwards compatibility with stables. Let's start a new discussion and see where we land. thanks, -- Shuah