Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200925171415.25663-1-oded.gabbay@gmail.com>
In-Reply-To: <20200925171415.25663-1-oded.gabbay@gmail.com>
From:   Oded Gabbay <oded.gabbay@gmail.com>
Date:   Tue, 29 Sep 2020 23:58:22 +0300
Message-ID: <CAFCwf12jX9sg8xjh4AGQvzyJaCu=bZaf+HjBqeauxV4Ry0A5qQ@mail.gmail.com>
Subject: Re: [PATCH] habanalabs/gaudi: use correct define for qman init
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Sep 25, 2020 at 8:14 PM Oded Gabbay <oded.gabbay@gmail.com> wrote:
>
> There was a copy-paste error, and the wrong define was used for
> initializing the QMAN.
>
> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
> ---
>  drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
> index a227806be328..5f65a1691551 100644
> --- a/drivers/misc/habanalabs/gaudi/gaudi.c
> +++ b/drivers/misc/habanalabs/gaudi/gaudi.c
> @@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device *hdev, int dma_id,
>                 WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off,
>                                                         QMAN_LDMA_SRC_OFFSET);
>                 WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off,
> -                                                       QMAN_LDMA_SIZE_OFFSET);
> +                                                       QMAN_LDMA_DST_OFFSET);
>
>                 /* Configure RAZWI IRQ */
>                 dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK;
> --
> 2.17.1
>

Hi Greg,
Do you think you can apply this patch directly to your char-misc-next
branch before the merge window opens ?
I don't have anything pending and I don't want to send a pull request
for a single patch.

Thanks,
Oded