Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v8 23/32] i2c: tegra: Factor out packet header setup from
 tegra_i2c_xfer_msg()
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Wolfram Sang <wsa@the-dreams.de>,
        =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200922225155.10798-1-digetx@gmail.com>
 <20200922225155.10798-24-digetx@gmail.com>
Message-ID: <2efb1256-dae8-34d1-1175-e70059b7cdec@gmail.com>
Date:   Wed, 30 Sep 2020 00:16:50 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200922225155.10798-24-digetx@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

...
> +	tegra_i2c_push_packet_header(i2c_dev, msg, end_state);
>  
>  	if (!i2c_dev->msg_read) {
>  		if (i2c_dev->is_curr_dma_xfer) {
> -			memcpy(buffer, msg->buf, msg->len);
> +			memcpy(i2c_dev->dma_buf, msg->buf, msg->len);

I spotted that this now shall be i2c_dev->dma_buf + I2C_PACKET_HEADER_SIZE.

I also checked that the enforced DMA mode doesn't work using v8 and it
works fine after the fix. Will make v9 shortly.