Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbWHGMtA (ORCPT ); Mon, 7 Aug 2006 08:49:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932096AbWHGMtA (ORCPT ); Mon, 7 Aug 2006 08:49:00 -0400 Received: from styx.suse.cz ([82.119.242.94]:7318 "EHLO mail.suse.cz") by vger.kernel.org with ESMTP id S932105AbWHGMs7 (ORCPT ); Mon, 7 Aug 2006 08:48:59 -0400 Date: Mon, 7 Aug 2006 14:48:55 +0200 From: Vojtech Pavlik To: Andi Kleen Cc: Dmitry Torokhov , Rusty Russell , lkml - Kernel Mailing List Subject: Re: [PATCH] Turn rdmsr, rdtsc into inline functions, clarify names Message-ID: <20060807124855.GB21003@suse.cz> References: <1154771262.28257.38.camel@localhost.localdomain> <1154832963.29151.21.camel@localhost.localdomain> <20060806031643.GA43490@muc.de> <200608062243.45129.dtor@insightbb.com> <20060807084850.GA67713@muc.de> <20060807110931.GM27757@suse.cz> <20060807122845.GA85602@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060807122845.GA85602@muc.de> X-Bounce-Cookie: It's a lemon tree, dear Watson! User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 41 On Mon, Aug 07, 2006 at 02:28:45PM +0200, Andi Kleen wrote: > On Mon, Aug 07, 2006 at 01:09:31PM +0200, Vojtech Pavlik wrote: > > On Mon, Aug 07, 2006 at 10:48:50AM +0200, Andi Kleen wrote: > > > On Sun, Aug 06, 2006 at 10:43:44PM -0400, Dmitry Torokhov wrote: > > > > On Saturday 05 August 2006 23:16, Andi Kleen wrote: > > > > > This whole thing is broken, e.g. on a preemptive kernel when the > > > > > code can switch CPUs > > > > > > > > > > > > > Would not preempt_disable fix that? > > > > > > Partially, but you still have other problems. Please just get rid > > > of it. Why do we have timer code in the kernel if you then chose > > > not to use it? > > > > The problem is that gettimeofday() is not always fast. > > When it is not fast that means it is not reliable and then you're > also not well off using it anyways. I assume you wanted to say "When gettimeofday() is slow, it means TSC is not reliable", which I agree with. But I need, in the driver, in the no-TSC case use i/o counting, not a slow but reliable method. And I can't say, from outside the timing subsystem, whether gettimeofday() is fast or slow. I assume we could make it work with the monotonic timer instead. > Please change that code. I'm not arguing that the code is correct. ;) -- Vojtech Pavlik Director SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/