Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4180474pxk; Tue, 29 Sep 2020 17:15:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+uTKE+MOkuVcKhxHNusbQz46E0PWBSGkkGgsNcnG5K3yOQL4VZ/CqWaXDxeICcMtDkvTr X-Received: by 2002:a50:8524:: with SMTP id 33mr737edr.123.1601424942473; Tue, 29 Sep 2020 17:15:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601424942; cv=none; d=google.com; s=arc-20160816; b=Cw/JV6TCOIdKC+3Npza64KV2Jr5T0it7gm5qosNdPwrLkprUS9LSvOnHIt4W1LNd54 p6OwATcU1cZcPJ/eCQA2+kHXOrFL/ZqB9So2BiXCxRRFYGGLIVyJqm4Cgm0Isi+r44rb jRlmFPAuMK7N8aQ3lcC1BOOF+gL7igx2McHJS7N2ZmXg/2FckFibZiGLQ8QAnMxUiFK+ HmdfJMRBSvYcz5XOOBehwjTzo+jHMTzQ4R9oZHCG9vPjy+vjgoygN1p84pRj+4rRx7kf mtdv0aODmCUgdt7k3xbeJ3XT4ytG12TCUmaU7yTx1mrJgE+JL+vcOwD1lL6sp9d6pl65 jMLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=TahisG6kUDutXipbSb0V03+wLD+q13trx54ypaJdagw=; b=Nn30Oua4SRSyXe0t2nITLkET9ryLhOcOUEc029GxT5MgQMLezjUIiSD4n/BEKg6Qrg Jc8rI6XmZ1VEll+se2E0AAGKsy9b2I7qHOkn2rjwGGoh3RVMyR55vSIvw86EolrP4BJ7 o3+I16ZNIZJZpkweMUYYjVjq3yII6DkolcyegNFZVzs8NCRvx8ramHfZjM+1CD8lbn3u jvvc0UvEmO6dh7uNvs+GHU69+BaDvMRzUB5RMZAMKyMwama3LnycfXHjEnTpf58FMfeT bkZPS0PVB7jyEiV31UyGF9zb0MLt1XpzB9wh10t1/nYrDJVC44+hYgUEoZK8189VVuOM vF4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=HKVw5IB0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b19si3855263edw.155.2020.09.29.17.15.18; Tue, 29 Sep 2020 17:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=HKVw5IB0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728892AbgI3ANm (ORCPT + 99 others); Tue, 29 Sep 2020 20:13:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728192AbgI3ANl (ORCPT ); Tue, 29 Sep 2020 20:13:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79BE7C061755; Tue, 29 Sep 2020 17:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=TahisG6kUDutXipbSb0V03+wLD+q13trx54ypaJdagw=; b=HKVw5IB0hKYct1Uuw5lklIVCpV xIZbt6VpLzXCuKp7AVdtX3indQiObrAjXZK2OA8P24B1NiVEZW/A/CW8G4xmiCSFCIEycEXrpEouN GS+AB1Cvtoj7VsWfmOjT+KRdFl+s3HxVZIg3Ny93a9/ZezVvUVePIQz6ShtlqxRWhw9HdQHTCxaHC WnUrWMAuzc91jJ+MwsUgE48yut+uFo9chQM+Kt4w8H4qaQaPyWn1RHEoamyd/j3qtSaqgvukDYnr1 vZDU2UeFKGWnuXF3hFi3G7/P6Bxhpyj558Ww/GKzSFZ1GQUuoh+irzDyWYnFTf5XArKfOGcgvQ0nF KKG3rqIw==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNPkS-0000MO-Un; Wed, 30 Sep 2020 00:13:33 +0000 Subject: Re: [PATCH 17/22] mpool: add mpool lifecycle management ioctls To: nmeeramohide@micron.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org Cc: smoyer@micron.com, gbecker@micron.com, plabat@micron.com, jgroves@micron.com References: <20200928164534.48203-1-nmeeramohide@micron.com> <20200928164534.48203-18-nmeeramohide@micron.com> From: Randy Dunlap Message-ID: <43f24e68-2625-36ce-1727-fcf981955b17@infradead.org> Date: Tue, 29 Sep 2020 17:13:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200928164534.48203-18-nmeeramohide@micron.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/28/20 9:45 AM, nmeeramohide@micron.com wrote: > + if (_IOC_TYPE(cmd) != MPIOC_MAGIC) Hi, MPIOC_MAGIC is defined in patch 01/22. It should also be added to Documentation/userspace-api/ioctl/ioctl-number.rst. thanks. -- ~Randy