Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4295407pxk; Tue, 29 Sep 2020 21:56:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBWKfiLmrHOoN96kbbWsvEFIs2bsovb4iUxreXdnOhl7pnhmNaZ7Kk/F04+wM1RepcDRR+ X-Received: by 2002:a17:906:48d6:: with SMTP id d22mr1023963ejt.462.1601441804486; Tue, 29 Sep 2020 21:56:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601441804; cv=none; d=google.com; s=arc-20160816; b=03YONIgtjIKlxowRqnw5LOurGZhcCtMvZKfxJckXORVh0PuFFuYdTSQjBHFoO/XJ52 THqhe3gi/JSsDIqHE/lBBTnogYxYIVpbQ66udVmtzTyO7pgTaeLP8x2lz26a7RuWPU+h VrzQVC0ZncO3Gi9IlP1hZRbACyeNiZepBr4Ti/nHE3oAmXFYCVDx5B2U+gzm9adokJX1 S+y/dPdf+ncqFYwe6luLG4DIodN4evoxqmcolkHXLEtdrsQMi4CbOmsXwsrZnXPKAGfw yOu/5BZDgzdpu8NPrGv3BRspE1v6UEy4wWhnI+XqAzs9MpWL2M0UzRoHM+GZASAmlSSh iwlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=gq15B5j+Up/qHefm+zsXhWBTHrFEobyYkI5096LcrPU=; b=dCrQp9JYLQrfJ7jU2HXbasISihS2o/1BV/LcSjNag/e0ZSaalUGbKf0xkFN3oHjzJm cEAhSSo+RGZKOyeX5HKpccxJ6YZG+Wt7nP7oBUpOqW7i7zzN33l7M6q+k4P0ISin6LZ+ BlD2xRJJGUFgPpzofwPUJeeKlvQ6HUpruKnxHHS8ihm5/DK6OqG7C7R32uPxWBu3pD8F R6VTpAO0zCHKmTk319HgyUTugRH8UEHeb4wRCmae9qV8p9kvIH9MmFkN1R8Y9FyquAWl zvqoZrSf0GgBPJr8NCpoVbs2bE6fTHENqcBakmO9acaUCsTr7E5sbGyGjYFYD8oRRICX CNzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc21si347167edb.550.2020.09.29.21.56.20; Tue, 29 Sep 2020 21:56:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725779AbgI3EzM (ORCPT + 99 others); Wed, 30 Sep 2020 00:55:12 -0400 Received: from mga12.intel.com ([192.55.52.136]:31011 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725320AbgI3EzM (ORCPT ); Wed, 30 Sep 2020 00:55:12 -0400 IronPort-SDR: jOYmpoi3BxEnB105Yduqe/PoXneGFYipkazUrRxfLYfA828YGB9WHaFLgV3I5xxej1SHSigmA6 p8dNLqilqEbA== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="141767286" X-IronPort-AV: E=Sophos;i="5.77,321,1596524400"; d="scan'208";a="141767286" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 21:55:10 -0700 IronPort-SDR: IAJJo5M+pPLzNlpO4DFYzHrLsiEpU4dcZqKJL8hCYBH0T0Mf4g0OeAIh5qLzDP4VHokRLCVdhq LEuDcfo2JQJQ== X-IronPort-AV: E=Sophos;i="5.77,321,1596524400"; d="scan'208";a="495478578" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 21:55:09 -0700 Date: Tue, 29 Sep 2020 21:55:08 -0700 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Cannon Matthews , Paolo Bonzini , Peter Xu , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong Subject: Re: [PATCH 01/22] kvm: mmu: Separate making SPTEs from set_spte Message-ID: <20200930045508.GA29405@linux.intel.com> References: <20200925212302.3979661-1-bgardon@google.com> <20200925212302.3979661-2-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925212302.3979661-2-bgardon@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 02:22:41PM -0700, Ben Gardon wrote: > +static int set_spte(struct kvm_vcpu *vcpu, u64 *sptep, > + unsigned int pte_access, int level, > + gfn_t gfn, kvm_pfn_t pfn, bool speculative, > + bool can_unsync, bool host_writable) > +{ > + u64 spte = 0; > + struct kvm_mmu_page *sp; > + int ret = 0; > + > + if (set_mmio_spte(vcpu, sptep, gfn, pfn, pte_access)) > + return 0; > + > + sp = sptep_to_sp(sptep); > + > + spte = make_spte(vcpu, pte_access, level, gfn, pfn, *sptep, speculative, > + can_unsync, host_writable, sp_ad_disabled(sp), &ret); > + if (!spte) > + return 0; This is an impossible condition. Well, maybe it's theoretically possible if page track is active, with EPT exec-only support (shadow_present_mask is zero), and pfn==0. But in that case, returning early is wrong. Rather than return the spte, what about returning 'ret', passing 'new_spte' as a u64 *, and dropping the bail early path? That would also eliminate the minor wart of make_spte() relying on the caller to initialize 'ret'. > + > + if (spte & PT_WRITABLE_MASK) > + kvm_vcpu_mark_page_dirty(vcpu, gfn); > + > if (mmu_spte_update(sptep, spte)) > ret |= SET_SPTE_NEED_REMOTE_TLB_FLUSH; > return ret; > -- > 2.28.0.709.gb0816b6eb0-goog >