Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4302112pxk; Tue, 29 Sep 2020 22:10:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLJLH1TNFx5tXt8v0AqRN4tuehSmRsYU308NzRQh+ZnUe0BPTvTjuz7Pvyo+o0CboDxptc X-Received: by 2002:a05:6402:10c9:: with SMTP id p9mr902088edu.156.1601442656054; Tue, 29 Sep 2020 22:10:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601442656; cv=none; d=google.com; s=arc-20160816; b=t6InyGzvykHZk1bpBDQExginuhXm/OyK979svS6e39ZG0mqpI2z/d4MpFCks9yQYjF 5ieEd85D+hjIZUie2bx4XFh7c07Z4nSy4rD3HL4OPvJV9VZPGbM4FZpV8sVnXh3jbqVr H3IPEDM/SZ8c6K8vyvfRP/ruCaWaqyEJqqYdRa8gwYqVATYU7AOTSubmX3Z5aZAVrR9R lpeYWxNfxd81xlKMW8xECfeQJ1VmGt60ZOErrIubd3MeBMaW9hqhsXHr+frxeA55omm2 uS6fV7TeyDKMl2EnqAkum2dPamjgMy8ZXbNu42OqTEDqQoDhdpU9zFRDNGojHiaq2igl 9+sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=WNjHpvu9SrqtX9TVx4PlNUC1kNcwMjCoZDyNMPucYxg=; b=RCJZIEjOhwgkD01qIktPnc8Y25i2tSmvFb6XvaEN4532UtrF9bPkYtmyWBJkCgjm6x 3NZC0SRNyKisB6W4H2c+ibCT0sHAxOqavO3wpORzb8TPxy9dQEptQ3uIgi1MiUUVBNWg esxBZXmVVij7t+FMgFrpAHCV5yGDAOh6RpdCaAnrfjrmr1bTI7SGHTEBm4voUsx42/tx e3IN/C2deVwbT2N8vsPDlUBsze41nf4cINgCfqsCdAVSavECa5LoVnVdkN+2a9PaHK8l TnHCYp07Z9vVai18g8XVsIzdxipM48+CVsXhZW+8FoGh90LnFBe9tI7NjhG6xjMwbeAN L8kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lh12si442972ejb.343.2020.09.29.22.10.32; Tue, 29 Sep 2020 22:10:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725890AbgI3FI3 (ORCPT + 99 others); Wed, 30 Sep 2020 01:08:29 -0400 Received: from mga07.intel.com ([134.134.136.100]:24900 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgI3FI3 (ORCPT ); Wed, 30 Sep 2020 01:08:29 -0400 IronPort-SDR: YsKGLSEBhbxslnml5eBNM2bTyjbBd1edMNBXPsxdaT6PHVFHPS0+UGHSfmeT4etPjc2Kd4MpLY cGoFBlmia4xQ== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="226516583" X-IronPort-AV: E=Sophos;i="5.77,321,1596524400"; d="scan'208";a="226516583" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 22:08:25 -0700 IronPort-SDR: 1zNnmGLO5DpVJkXdDf7JJ3OdVAnfUHijc1TOvsSZKuDZBsacmzZ4liUuV1fJIg7b1avCuaOmNz zm9BDMlQ2cvg== X-IronPort-AV: E=Sophos;i="5.77,321,1596524400"; d="scan'208";a="338939911" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 22:08:24 -0700 Date: Tue, 29 Sep 2020 22:08:21 -0700 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Cannon Matthews , Paolo Bonzini , Peter Xu , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong Subject: Re: [PATCH 02/22] kvm: mmu: Introduce tdp_iter Message-ID: <20200930050821.GC29405@linux.intel.com> References: <20200925212302.3979661-1-bgardon@google.com> <20200925212302.3979661-3-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925212302.3979661-3-bgardon@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 02:22:42PM -0700, Ben Gardon wrote: > diff --git a/arch/x86/kvm/mmu/tdp_iter.h b/arch/x86/kvm/mmu/tdp_iter.h > new file mode 100644 > index 0000000000000..b102109778eac > --- /dev/null > +++ b/arch/x86/kvm/mmu/tdp_iter.h > @@ -0,0 +1,53 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Kernel style is to use C++ comments for the SPDX headers in .c and .h (and maybe.S too?).