Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4303263pxk; Tue, 29 Sep 2020 22:13:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwv7JhCzpUUJFGCmImYjY3xJ+rxlDx1FxpK0yMuFeeBnQjvfW7D9FDWsvGm4e1OFyrETMCR X-Received: by 2002:a17:906:3553:: with SMTP id s19mr1040696eja.178.1601442832531; Tue, 29 Sep 2020 22:13:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601442832; cv=none; d=google.com; s=arc-20160816; b=etwi+LP5jUBZMWEzOguHcBIcSlr+BmJ9XcC4Y2wDV3ImoP5WQ+kyZQtNhEF6Chg2G/ WEZiQZl1KJcA7P0MdMM/271X8f+2hiRkeoEAGE6B4tSM4bX524bY2BFOjPdNZZU1nW++ 5zrt5iK+QGnV7Ggd4xuB6e1nOoiqdgiT7PwUH6m9yY0CVhqkbyNXp4dBE2uyFeIP00xN h1TcKFEONnNR7nVHZuQL3EVqfkvlqrCF8o0Ix1ErZSfGUAJcmJFNJgnf5ueJtXFDZYQG 3h3HQbusRONJHue3wYBJkEGYuTXRcOMK2dV/anpF8YnvxKXfsYWiVyQ886pnaEwRRALg BqSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=+bNH00/3TyfIl7ZmwUbB3/9mSNJL/xs6urc84WGD8GQ=; b=S9lyb0Yi3NzJccd9Gkr5vkXwY9vBwQDoO39llEeqRU3y02XOLt0yJM7qAmMaWtr3tp cnY1FHuNjim3Dc67VH0JWxtiqGFfldD2+Ja8jhW1BSWCLLlvLdeMnKQuG/Z4d8qTNX52 61/KzHdQo25yk1TDohpOk6z4zkBsMuL8ZaEjQ5Utio3IdodWVy+6+aqRI8aPn9Z8WzxR FKAMcgDKV+AjMNBKanLzox3S/FzACjAPCM/iviKdonfW6g6hiG8Xd8/JcCJlJeNserbv t7J+79SLl2TgxoEkVxfMeX3su2AYYiI7eRDTFyELXPmews8PtwnE06uENs+qgavV74Me AFoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=G+eIUnDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx24si434545ejb.449.2020.09.29.22.13.30; Tue, 29 Sep 2020 22:13:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=G+eIUnDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725852AbgI3FKL (ORCPT + 99 others); Wed, 30 Sep 2020 01:10:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgI3FKL (ORCPT ); Wed, 30 Sep 2020 01:10:11 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A76F8C061755; Tue, 29 Sep 2020 22:10:10 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id v23so466814ljd.1; Tue, 29 Sep 2020 22:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+bNH00/3TyfIl7ZmwUbB3/9mSNJL/xs6urc84WGD8GQ=; b=G+eIUnDiiFVQqLzVvhzNbtgRd8FBnc+NxeAyEMeLgwyr3gEs/cYEv5/Nr4xHPbeaUH R2+9LBdcKv2hwfzKBaeocX1H/DCOXwH0lkIuZmUaPBobHONWj+WEyV0rQY6xvHXpjc68 Ky0zPRMmYSYRLlw2zXvJbBZjPZdsNWpR8JpeCA2nHzvcChEqV1+BkZI2Dlv3a+3zrekF IqBaxtYCYmnwgy84Fy55K72QFMB7DfqVQku9auLfwv2G76FMU/YnbASLCbOEo0cO5ctS o4JkTfi2qCiqyHsk2HInQR4mbI2fYRfE0oYBkrJKIM4QWl/jld/n9JgQhf/EVBttuPJK 6Mrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+bNH00/3TyfIl7ZmwUbB3/9mSNJL/xs6urc84WGD8GQ=; b=YH2WNQ2moD6eNTQvDMIgfL1J4FRgbFoib2M2qY67kKsJUrXSUjedYFCUSNpi5DOdLz ziMf9GYep/9f4snoGtZwLvWj8bpwBYQMOrieKgj1sXCKYsXVAIySCHcp5OgjLwE/CnsZ b0SFTt0RUMAr9d24vLa+Yxe+zKH8imCnbGzEwk02iDSJO4uKAe9NoSEpmEluwHKuYBL1 j8MS9pibecZgnDEST7A5YxVYZ6FnrSsrfWJ/IaD66laPCZES81fdhlaT9SZdtVQpcUJS +EjjWX7iGOtXrrDn0S2wlSskMXu/Wbk22Bz3HT3QqCrDtjWWFgRnZaWNH08iGMpNM9Mz TEYQ== X-Gm-Message-State: AOAM532KVZ4O32mpvANENUkd/S6jhg6+2WfvEW5AIRuUui3/BLrRe0A2 NBcTBJSlwSx/ZJ/RhMwMqBAWC22WCVQ= X-Received: by 2002:a2e:3304:: with SMTP id d4mr292406ljc.440.1601442609011; Tue, 29 Sep 2020 22:10:09 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id x73sm54949lfa.94.2020.09.29.22.10.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 22:10:08 -0700 (PDT) Subject: Re: [PATCH v2 3/3] iommu/tegra-smmu: Add PCI support To: Nicolin Chen , thierry.reding@gmail.com, joro@8bytes.org, krzk@kernel.org Cc: vdumpa@nvidia.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20200930003013.31289-1-nicoleotsuka@gmail.com> <20200930003013.31289-4-nicoleotsuka@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 30 Sep 2020 08:10:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200930003013.31289-4-nicoleotsuka@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 30.09.2020 03:30, Nicolin Chen пишет: > - group->group = iommu_group_alloc(); > + group->group = pci ? pci_device_group(dev) : iommu_group_alloc(); This will be nicer to write as: if (dev_is_pci(dev)) group->group = pci_device_group(dev); else group->group = generic_device_group(dev);