Message-ID: <44D75151.5070504@shadowen.org>
Date: Mon, 07 Aug 2006 15:42:25 +0100
From: Andy Whitcroft <apw@shadowen.org>
User-Agent: Thunderbird 1.5.0.2 (X11/20060516)
MIME-Version: 1.0
To: Andi Kleen <ak@suse.de>
CC: linux-kernel@vger.kernel.org
Subject: Re: x86_64 command line truncated II
References: <20060806030809.2cfb0b1e.akpm@osdl.org>	<44D742DD.6090004@shadowen.org> <p73wt9kprng.fsf@verdi.suse.de> <p73slk8pq6s.fsf_-_@verdi.suse.de>
In-Reply-To: <p73slk8pq6s.fsf_-_@verdi.suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1114
Lines: 31

Andi Kleen wrote:
> Andi Kleen <ak@suse.de> writes:
> 
>> Andy Whitcroft <apw@shadowen.org> writes:
>>
>>> It seems that the command line on x86_64 is being truncated during boot:
>> in mm right?
>>> Will try and track it down.
>> Don't bother, it is likely "early-param" (the patch from
>> hell). I'll investigate.
> 
> Following up myself ... 
> 
> Are you sure it's a regression? 2.6.17 does the same
> and we always had that 255 character limit (I tried 
> to increase it once, but it broke some old lilo setups) 
> 
> i386 should be the same btw.

Its not being truncated at 255 characters, its being truncated at the 
first space.  This is coming out of parse_args, which dumps '\0's into 
the command_line as it rips it apart.  We now only have one copy of the 
command line (in x86_64) instead of two, so we now expose this trashed 
copy in /proc/cmdline.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/