Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4344269pxk; Tue, 29 Sep 2020 23:52:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwROdywk66UfaeMOxBjjnRpXMrLHsElD6vlD/Q6vdcvyCrLyC/o0XstEcATsE0ss9hv4KJ1 X-Received: by 2002:a50:84ac:: with SMTP id 41mr1116128edq.361.1601448722566; Tue, 29 Sep 2020 23:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601448722; cv=none; d=google.com; s=arc-20160816; b=VJ/pY4PDvcBdPK4RG1pw1yk8hAIAlox2KJ6mS7XTCMa8CKMNjhwUTxJ1VILTmO/GYQ CNVY1dyqoAtE/9s5AZXgVZdPaUS+c29OE85pUXRHH6MxY/YVddfzRz6l6EtVIXNUvFuX GZ45GyGjd0l6MZ/SYauPxNYQ/AlVEaxaluJcnUdOhcFwyF2nFSnCYPCnWZgU1eCkShi9 gWguQyJ4lAav4D1pOBl2qrKg14JgL4vEtImdB5uizlmn6eW0/I5CpFZw6bPawXxQqU8t Ebqe/b8d4B2bfO8TU6EpYDlyd3xgITpvjH6uGVULC6HCyOKdDeBwGSc85Tg7h+5NVy1i VAxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=0Cg0ycDtO+B0XeEyD60ZAnUts/W0lzugMtbQ+pnKkhA=; b=i1KeP6ocqGi0snae3nAxecE/DKjM6NLUvcs/lF8UxLmJs44dDJNwWoDE/WwahXNBcw v6oETEqKWhBs7w9zUziTCPHiVPsjqLTR2pCGlIQHgiBZjQqtlopTaNaundPqEdYZVCks vPbfweOZFpZ8QQyRNC2lkLpC+lSqjIT7sClpkM8A3CyeXN2XLXAY8aEaxdDNzo4nbFw3 R3+bW+J2azu2fMuI+KMigTT8dIhC2HD7iSlvwshQXuagjhxURDBav1gNpG/bPamKYdY7 rD2kZZcMkcd+QzsKwSndSM+9/f6+zTatkzIutd+AHa4KSnDIdnxwLznV7uwMXIqY9Wb5 Q7kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="v/d/IXax"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w19si559165ejo.726.2020.09.29.23.51.39; Tue, 29 Sep 2020 23:52:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="v/d/IXax"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725776AbgI3Gsg (ORCPT + 99 others); Wed, 30 Sep 2020 02:48:36 -0400 Received: from z5.mailgun.us ([104.130.96.5]:15505 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgI3Gsf (ORCPT ); Wed, 30 Sep 2020 02:48:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601448514; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=0Cg0ycDtO+B0XeEyD60ZAnUts/W0lzugMtbQ+pnKkhA=; b=v/d/IXaxAdCWHAPoTeTykshQIhW7UtZby/OjNcYE07UNW5l5PmUSyR+UBctPwkcBfAeo5uai 3nfkRpryxO7Wlglfpj3KbxpmMtFTLjv54Zze4z4eGJdn9hU1cnjNI6pPLmaOiBCi2+IZnJia cdBmQ91FMYTBEd+xv1Ib2yhYCZY= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5f742a4259892db41fe3ff07 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 30 Sep 2020 06:48:34 GMT Sender: akashast=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C399DC433FE; Wed, 30 Sep 2020 06:48:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.43.98] (unknown [47.8.99.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id B640FC433CA; Wed, 30 Sep 2020 06:48:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B640FC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH V6] serial: qcom_geni_serial: To correct QUP Version detection logic To: Paras Sharma , Greg Kroah-Hartman Cc: Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <1601445926-23673-1-git-send-email-parashar@codeaurora.org> From: Akash Asthana Message-ID: Date: Wed, 30 Sep 2020 12:18:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1601445926-23673-1-git-send-email-parashar@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/2020 11:35 AM, Paras Sharma wrote: > For QUP IP versions 2.5 and above the oversampling rate is > halved from 32 to 16. > > Commit ce734600545f ("tty: serial: qcom_geni_serial: Update > the oversampling rate") is pushed to handle this scenario. > But the existing logic is failing to classify QUP Version 3.0 > into the correct group ( 2.5 and above). > > As result Serial Engine clocks are not configured properly for > baud rate and garbage data is sampled to FIFOs from the line. > > So, fix the logic to detect QUP with versions 2.5 and above. > > Fixes: ce734600545f ("tty: serial: qcom_geni_serial: Update the oversampling rate") > Signed-off-by: Paras Sharma Reviewed-by: Akash Asthana -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project