Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4395539pxk; Wed, 30 Sep 2020 01:32:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLpFn6ZQr+jTnU9cQJ0Y5388XPf1Vd0OZEG633Mofl9hXijV6QB3K5h53ogcT8U/mW+tXv X-Received: by 2002:a17:906:4a8c:: with SMTP id x12mr1732291eju.271.1601454767733; Wed, 30 Sep 2020 01:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601454767; cv=none; d=google.com; s=arc-20160816; b=f/9gCGeILOv/saHUdq2smtBqCxS7Tf2RjVGWOWgH5QGDUorSgguSIWBuIkSaaQ4xyv YWy6KaDajy1ZIZO/X0uIzMWQXR7lI/DlmWxIycX57LGSQHYfSIQwaLdhqe0f881imkrs OGBDLmc8r9giaLKLoSeTzwY8txBt17zMxxul4/jXqrBWV7IergTf5UG8YMgLo3iWZzAN SMHJOCCG9LziGzRgbNSafg6GA6ZTMTLv9F3CcRF9bwwM/4TdYibtt2FzRCw9WLqaCO18 ud4BqyQnGwUpfdzRAF6XyLXchGWDeNbls0HUw97SZkUAAkFZk5KlSV8WmSQXoWMInU7s GcSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=m989BjzdNWBUQv8KIho7qjR9BxP0IepkawJx1H/XAnI=; b=ajK0THDBCg/zRA8VlOo7isen4l1hWWSjJPW+F068zbXWtsBY6mjht2CZVDQg7K0Ohq PLZwWLZKu2FUjK/tQKnvt00JrBvtu8jFfSIUkmCabVLtOgl3jFu5dFHfLiSHeKsAEk7k xZEMX7+jPodV1E60PgV4G6EvbMoX3BkxVuDd2GdM3fExP/jiabUPpftD2T1Y8JrMWttZ uXmvc9/SXlh6SbCy6fwW+t62SMaRUmzmEr25leMFSt9kIpVQuolg2i5UmCM/S/bKQly1 LupWy7DZPPYn2mszToGFY0cSIKyPFxmaD79npc/eSmptuWiwcfclAmw4nl2IZotQlxQM Z4JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I/9Wyw3T"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si657879ejf.594.2020.09.30.01.32.25; Wed, 30 Sep 2020 01:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I/9Wyw3T"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727657AbgI3I3Y (ORCPT + 99 others); Wed, 30 Sep 2020 04:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgI3I3Y (ORCPT ); Wed, 30 Sep 2020 04:29:24 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37FC2C061755 for ; Wed, 30 Sep 2020 01:29:22 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id y11so1102647lfl.5 for ; Wed, 30 Sep 2020 01:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m989BjzdNWBUQv8KIho7qjR9BxP0IepkawJx1H/XAnI=; b=I/9Wyw3T3aSsnU2k68PFKT6j9HxBNIxap5h74Ug9ociWfVd1W1g/el8JT16tp4BJk0 xF+pMZ1NnGz2R6XMvCQNSzxsN2oiRsKK8XeZr5sMUpFZ4xYJ4Gb6SVko9p3Yd+ub2qhB 4rREnF+ym6uJI90GAeOql6DdwKHq5+5nAU/u7jegFfxCoLWQknC2NeOOT13v83sbWtsz Xd0GMWnxhEwjqXi4HNPlnF9f9rE263x55F6CYP98FEpDQaRcIrIvyZPDS8gq02jkAfei aD55Lxy4phqDfZ8A4ZTe7ve8o69sV2pYOpFeMn/2nQj/MjzUqL+aWL0C8fZN7dYhzsHs lGXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m989BjzdNWBUQv8KIho7qjR9BxP0IepkawJx1H/XAnI=; b=p5441WBAzbWTOPoo6bK/nEhql1JMpSj3Pmu9EVcVbE6ZysTy8draPlmYT+rvf7REOo g0Or6GItn40Nzh78a+7s/uDmsbou99ebI1eBLHieavmUjqketxa8A9GIdCuxqwonm8jg F+zjdSOyjDblyUrSLQJNQMag+ajueOM4Re6SXerAYEb8oUDAY3xlD4/x042FmuA2yat8 Fcfyex3V1KLZvsGffkuU8WyHaFdoeKdDF0vTWl0n+tqRsMrdbDPTQ/xnflPItDu+PKF1 aMXFBOsf6V/kAVa/yC9s3fS358KWk/Ga5n0J0VNlFQnqFBcc3qhz7OmwXFQBGCsLldwI SU5w== X-Gm-Message-State: AOAM532QJBTdAVhtRgf6NnjshCRbwis8PGU/os7AkvDne7H15iwMMxd4 qBIwqwOi6E/4+V/4dOgAetfye0oVQS1MIU6lW4SDUBigmrarjNiA X-Received: by 2002:a05:6512:370b:: with SMTP id z11mr453556lfr.571.1601454560622; Wed, 30 Sep 2020 01:29:20 -0700 (PDT) MIME-Version: 1.0 References: <20200925235541.GA28030@agrajag.zerfleddert.de> In-Reply-To: <20200925235541.GA28030@agrajag.zerfleddert.de> From: Linus Walleij Date: Wed, 30 Sep 2020 10:29:09 +0200 Message-ID: Subject: Re: [PATCH] bus: arm: integrator: fix device node iterator leak To: Tobias Jordan , Sumera Priyadarsini Cc: Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 26, 2020 at 1:55 AM Tobias Jordan wrote: > In the for_each_available_child_of_node loop of integrator_lm_populate, > add a call to of_node_put to avoid leaking the iterator if we bail out. > > Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules") > Signed-off-by: Tobias Jordan Incidentally, Sumera Priyadarsini has already fixed this. Thanks anyway! Yours, Linus Walleij