Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4402437pxk; Wed, 30 Sep 2020 01:48:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNPA7lUVp48NO9Ofi1za3RRk1c1/E8vkxhzoGx7IwQOCAuNSHLOibwJbPTORZzzTq3+m6j X-Received: by 2002:a17:906:1909:: with SMTP id a9mr1662572eje.127.1601455733958; Wed, 30 Sep 2020 01:48:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601455733; cv=none; d=google.com; s=arc-20160816; b=q+Dp68uEZlZNMai9XdjFF0fUvTNNlTXCVJk6d4MzVGcYfzDhFoBABkjefmMbRRhoI7 MJkCLJ0KFKxGMcB+ysleB6chhcF3QPU6Nk+PhuSozlVM9Ab96zBNnl3U2r8UE0UEOAIV CrNlq3mae37bkb7d41rlB1iudSF4TI1Z07cfY8YSi7chqN5Vrk2ZKStPEs6GOLjLCPau mUZ3PjUd5vww2N3bFT4bes9OZ6oYGx1KJHDQBYuft7WKKaCdSw4LIDMUw5NU9t78Q1Ev wtZxM8CXLC+PTXAYANW4AuHhQNYvalyCsmKWYAnJFCIzBpEROFedyB7ui8iGEFJIuDTV zCkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=cr4F0zeDS/obqT3hxezbEXoAuNHnHKvlXLl42w4NaIs=; b=Zwq9+gV8GPtehpwSYH+RVBc7Z5cVUWjzPbjLi9ebJSix/R/pXrXq6a734kQux8T7YV 7w9sBO058mpRfRwGM8jm/NIywfFsggDplKYKzz4Tr6GOwFudeEacfP99VTvPWhVntph3 LjXypGwLfVpIc0x++6iP/eTPVo6TTHrI0o1p4IzCIqSYG84zSWQuXmkU6SdNcxtm083G Zh/mzc95YgFy3kb1wZIMzvoAc1LcNlv5TvJKZurQ8/reipFnH1XLO/HQHjPMgQfpeEvV SxuNAroyMU0sW2CrD12R0ar0PAcbuaL+8Vw7L3jnXQvb8OBvD3kglY2jjnq/cEspvM+j 9Dog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uvnIFiV7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s20si552300edy.352.2020.09.30.01.48.30; Wed, 30 Sep 2020 01:48:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uvnIFiV7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728367AbgI3Irb (ORCPT + 99 others); Wed, 30 Sep 2020 04:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgI3Irb (ORCPT ); Wed, 30 Sep 2020 04:47:31 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B72F6C0613D0 for ; Wed, 30 Sep 2020 01:47:30 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id y17so1150695lfa.8 for ; Wed, 30 Sep 2020 01:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cr4F0zeDS/obqT3hxezbEXoAuNHnHKvlXLl42w4NaIs=; b=uvnIFiV7FZ+zzxcN3L+fCOcCWuTR9m5Qa6z3OabpBiheRDK7oh62P0AGiTJ6XmPIb/ LbyEdCxFU83nObD/1diqJRWJlStu0Z5jC8YKKXrNm/btn67XGWCMhOkviYDGeFTih0lr tPMt6Whw+O1h3ZbA2rZ5mimAi8PWwVpQy4ek4HBScVoprn0iLZoVa0t7Netjtmmiil/V REimQjACKl1DgKtpQ4Yt7dPbJTE0au96lQDi/QUkdIMgVoR80ZwpE1cTIF8nKW0ss8ix AOKNfOOB7C9QqYFsUjoqnadPe2jn4unxwRkIBRv3NkTXHBsNHuJzF4m8hRO5E7+PmYO0 svaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cr4F0zeDS/obqT3hxezbEXoAuNHnHKvlXLl42w4NaIs=; b=Vm/GQiCB8hxN1s1LxAbKijNyJjnT2+Wmi+Eu4ukx4mlj7+eDuFvxcrlLud8l1j+sOG 4ZejypDWdwiiGSmvj+7mgMDIIDfqGVJ/tufoPrsQ3vI1ikNMgKLs9d93bCApEUlI94AN 85s0RZt49t7LzWjF9F99o407XXAcEdZ44sOiR3GTsa+TzW5JpNPhblCFAoBxltS7ppqE ix5cTA9+99skmNQJLOtGTtzrPXhXVdW0e4N2cNQwz0a3uch+MeQQyXnzWw/LQQNTzt1z qWDFskz9bVtUiPcYqfqxpETICsGPNVFG8h2E++yoyW2Us7TEba4T1Oxtbj/gtW5JGvID F+cw== X-Gm-Message-State: AOAM531Y++nwJykXIcpiXAdsd5HJAhq5MnGnEySc1rkmBfDJ8SfPn26e KVeoF/JO6lA+XOOtF5mKS7zvRDAFHYbCZKJxNEp+CA== X-Received: by 2002:a05:6512:20c3:: with SMTP id u3mr473893lfr.572.1601455649061; Wed, 30 Sep 2020 01:47:29 -0700 (PDT) MIME-Version: 1.0 References: <20200821075452.1543610-1-enric.balletbo@collabora.com> <99821f85-9a38-7591-f982-872603b6ce8a@collabora.com> In-Reply-To: From: Linus Walleij Date: Wed, 30 Sep 2020 10:47:17 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure To: Sean Wang Cc: Enric Balletbo i Serra , lkml , Collabora Kernel ML , Matthias Brugger , Nicolas Boichat , hsinyi@chromium.org, linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: > v2 seems the same with v1 or I was missing something. > > I just thought we call devm_ioremap_release to explicitly to free > resource when a certain failure occurs after > devm_ioremap_resource? What is the semantics around mtk_build_eint()? If it is called on the probe path no explicit free:ing is necessary: anytime probe() exits with an error code, any devm* resources will be free:ed. Yours, Linus Walleij