Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4403279pxk; Wed, 30 Sep 2020 01:51:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0wwbibNV6zqhizodPTmrdqQ5jJ2V6NqiAXWhRVjSWYedKaHedckha7FnvANE4DWO7U7qH X-Received: by 2002:a05:6402:1544:: with SMTP id p4mr1524292edx.346.1601455868626; Wed, 30 Sep 2020 01:51:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601455868; cv=none; d=google.com; s=arc-20160816; b=C89tuwY8oVewL2kaGNbpnftHPqIGUWDon/VrPUYNFo4zkdDK8XwNH9VCuGfJ+boxSU ldV/ilvHEXv70SKh/A4d5p/MTP8DEh6+/1IrGr9yUg9xjxG0dtkrKJRxCtvA1pgx7LFr imVHeC31nsnn46H8GS92gv1Q9OVHbBF/0hIPiy+C5McAEH/UsDhVzWbvtXMTycfWiPn6 0MfDQpOjMA2yo06w9X8Cpruq1YegvItRXHAf761c1DnTj8LsJ3u2Jy+8MQ0KV05ALA2W MKP4KVojm7FXZBdhKn7m8ozeNTRufSgj2IIYjOfy2NptPsX9wYTOeIa9L0TbEMcTtdw8 Nr7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=LwsH4RNzM7M1YZuptel9pzVtCDIa+ZWwO2h5LWJGBOE=; b=gjCm7voolTnVG7JmyntzOWhibUHO0cRhd2ilc+ivjsEw4PzaR2ZHXa1dfd4WYse6Eb 7dVso/hGBaoaJnjthKsfpNyfG6M1d9Y/DaDPd2zaliMiXhKmj9N/sa0aF8+D5V4j0JK2 O0Xnc7V6eo+OVZNCT4BY2bvso+2GlK8WSUAjbnXkihc9qHe3uXi+07xGB8n9jKJ0wgss QypHpHRyaMq817Ff9Znk4WVcUI8oazBtYji9yq1IHgbDMj387mSgYcMOeFpnXU40wYh3 lqJILnepwDeoqiA9Mtgox3LG7aA9KGZ92WmuByNbw3tGqRLLkkkQAXx3vazWScSEQhTP x8mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WiP+6Tbs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n21si552473edr.327.2020.09.30.01.50.45; Wed, 30 Sep 2020 01:51:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WiP+6Tbs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728662AbgI3Isx (ORCPT + 99 others); Wed, 30 Sep 2020 04:48:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbgI3Isw (ORCPT ); Wed, 30 Sep 2020 04:48:52 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56086C061755 for ; Wed, 30 Sep 2020 01:48:52 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id w11so1174819lfn.2 for ; Wed, 30 Sep 2020 01:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LwsH4RNzM7M1YZuptel9pzVtCDIa+ZWwO2h5LWJGBOE=; b=WiP+6TbsCK2Y5YTT5RJHL4rQtHQ9Atapoj/vpKrfxYU4qy9/48B0y0IwPfJT2Spbfb 4vpLswz7BfIvYDnM2tl4py33Wbu45yki8K6u2dmQi3IYnCoWBxxJh8Vi+cROnJW9bwuD TSezmy3VfFlrI25skDsudj2l71nrUDtQTWOTw3gmcXNqyHwjfziUK6sGQQR8HNZINSLA UAlo9M6y1StSHvcqHEC0IJ+NHNNOJSRN620b48DZxmSJeRxmK0vLD8KTCgJIOCoqLvaN wLzOJRvsENpsPuBe3E6aoXbrmUp/riajJly+8g6+CZv1xK5L6GP0idVMa6US7ZnjDvnh etaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LwsH4RNzM7M1YZuptel9pzVtCDIa+ZWwO2h5LWJGBOE=; b=MNrqMXqcanfPwWDjIyqMo+gMeWuvUYHpjFHb0Awf0W/aHr90UsXF4F7/mgaLIGNRQD cV7BNGxwLsbwxc8l9XAx6hhzOYQADIOaINAMri+Vo8sItVGpId+5kD/T8iB4Ke+8qfEU YMNX5ixlrKXw22dzkA2scn1lyV7jNdcHzcZyN/epZmcsVlQZFeDXD2vkBu4uhcr+cfgt K6L9KGinLlFVaD1pra73WpWsWL+Z0wnuScPB3Dcc3kZ5gGAE9uzaXgtW9mCpq/HMu/7o 48VrCbsTAp41ZKfzSM4mlm9VC6LLreP63tMM/0gEXdGl3BLZU6Kf1t+xIzljhCd1BCZo Ynlw== X-Gm-Message-State: AOAM533nFPT/YFDyJ2ur0RHGNMLFoBVjAJg0Ir/K2M9DkYW8YyBBuYVR VBqW6NONcEkVPR0+ViXiyaQdzUiRCVi48E0kV6qMag== X-Received: by 2002:a19:1c8:: with SMTP id 191mr478715lfb.585.1601455730766; Wed, 30 Sep 2020 01:48:50 -0700 (PDT) MIME-Version: 1.0 References: <1597922546-29633-1-git-send-email-hanks.chen@mediatek.com> In-Reply-To: <1597922546-29633-1-git-send-email-hanks.chen@mediatek.com> From: Linus Walleij Date: Wed, 30 Sep 2020 10:48:39 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter To: Hanks Chen Cc: Sean Wang , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , CC Hwang , sin_jieyang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2020 at 1:22 PM Hanks Chen wrote: > check mtk_is_virt_gpio input parameter, > virtual gpio need to support eint mode. > > add error handler for the ko case > to fix this boot fail: > pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2] > lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris] > > Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg") > Singed-off-by: Jie Yang > Signed-off-by: Hanks Chen > > --- > Changes since v1: > - update Singed-off-by > - align with pinctrl/mediatek/pinctrl-mtk-mt*.h Patch applied. Yours, Linus Walleij