Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4410250pxk; Wed, 30 Sep 2020 02:06:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4l9V6Kh78xOump7k9/0t7PrQxIgCrLbawLqWn0B7D0fiDcIz6HJf4FQF2wvbSlspiiUdV X-Received: by 2002:a17:906:cb98:: with SMTP id mf24mr1899077ejb.90.1601456774249; Wed, 30 Sep 2020 02:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601456774; cv=none; d=google.com; s=arc-20160816; b=Sby1DwO3iM0yBCE4cqAf++Z16MmSDXvb+ft5fxb3sqw4NrzSDh6SArc4e5shFC5aAp QhbeLF5yn8eL/zdPVx2ZdvFs++qanoPwFlIeYe4XdrfIROwFAsP/kFgF1LjSrjBWao1k edT8lWrgCLsGW1rNkz5l92LgvHA6bW7VDaGAtY//ybGDlO/ZBfHQ0P/vJCX0lBfdfZdL EnbKGBLwV5b4ohmApXtfOCP/+7SulVdFcD2xYR1V0GglPFxTmIUxir6fqUvOYD0Jr5iJ iNNKN3vCMnCr4rctoi1nDDtWC+JXbjs3rCwj0wqk/tliI5DIrM6Dx6ZX84533NIO8NM8 8ZzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=amOdIWMT2t47nUPn9oLAhD0z63sST/QxQcoswuZyi1w=; b=TDJA//qiAWxbd2v0IuPr7nxQTjxECn28Bj+jpM3eQ7RjUvyKQwtUZ3Kf5ly0BSqUK8 w9+8lo1pxOeVjuiZNaCYwCPJtQmlJgrc0Q5yme/9dFHUv1N4F1eutae/Sqgh09Mv4Kom qD4mDxeMo0/Y5Mi7rodtT1LOLfQg7qxjm1jGRS5EoK9CAluC0EONmP+Xb9pZCkWuo2YZ U7BrJTsIotXjT1feIyC9s8J6mkoCGLMbMoqVfH7CGzO2RqOGqkXq4ielcsiY7uFuLHYh /AP1WjaOfmbN64GE9k5ITtCEarOrB9He2wY5duQFyfhDcvm6ZY7g151kPccxYDhOlRJ6 d14A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qn11si735097ejb.303.2020.09.30.02.05.51; Wed, 30 Sep 2020 02:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728587AbgI3JC4 (ORCPT + 99 others); Wed, 30 Sep 2020 05:02:56 -0400 Received: from verein.lst.de ([213.95.11.211]:43862 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgI3JC4 (ORCPT ); Wed, 30 Sep 2020 05:02:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9EFDB67357; Wed, 30 Sep 2020 11:02:52 +0200 (CEST) Date: Wed, 30 Sep 2020 11:02:52 +0200 From: Christoph Hellwig To: Paul Cercueil Cc: Christoph Hellwig , Stephen Rothwell , Dave Airlie , DRI , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build failure after merge of the drm tree Message-ID: <20200930090252.GA9357@lst.de> References: <20200928135405.73404219@canb.auug.org.au> <20200928060427.GA15041@lst.de> <20200928113415.GA555@lst.de> <72ADHQ.T6LL1SHQF0RG3@crapouillou.net> <20200928121002.GA3219@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 03:31:28PM +0200, Paul Cercueil wrote: > It's allocated with dma_alloc_wc, but then it's only accessed as > non-coherent. > > Anyway, for the time being I guess you could revert 37054fc81443. But I > have patches on top of it in drm-misc-next so it's going to be a mess. > > If we have time I can come up with a custom dumb_create() fonction, to make > sure that the GEM buffers are allocated with dma_alloc_noncoherent(). Is > there a dma_mmap_noncoherent() too? Please use the lower-level dma_alloc_pages and then just insert the pages directly using remap_pfn_range. Although it might make sense to eventually create a wrapper around remap_pfn_range for all the vma sizing sanity checks. > > -Paul > ---end quoted text---