Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4418528pxk; Wed, 30 Sep 2020 02:22:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwv1S4PzFGOyXQMPiUiEHHX07gUPJDeKmIzkdAiuDjhXphk8SN9YkidMEmx/znAFtQz+gmS X-Received: by 2002:a17:906:cf8b:: with SMTP id um11mr1951122ejb.540.1601457779136; Wed, 30 Sep 2020 02:22:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601457779; cv=none; d=google.com; s=arc-20160816; b=PmyCHKtOG8Cp1MaAI3F8dAotVHy3JK4mmyM9fEHsaUdD+14yAElEvEFoAyzAI3a2/j H35ICCzS9DrlLhP4eQhfAXZehmM/xRBsIe1ns4pLWWvoANZ6aExFa1lwdSo5HQbCbS2v JslBoAj+ZdsGRNOQjTBtcaP5YV9VH64eeiK20fnMe+cAeZQveru50g9tkkeOm7ZBsdWc L9N66JWpDMYoLLWTJdRu5l2cmhf5J9gMxZ+J5em9pAVjGbf05eOijO6wUAlfv3Qt/Ug8 +aujnttyMGLOo4l3pICb8Co1sR82H+WSR+rHxKlaapfeBapAgDTJbEbvfQJn9YjThkdt Uhbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=auwG86d8FZrM4HNvXfEmKs8kmXKeLdisJmLvrKOfASM=; b=UeU16yHJ/vlqEL4SyvUkx28UMeTls/SeBaV2E1lUoNIl8rcIPt5rd6tX+LndqQsayA cq0iXqF/KMaFXBkqbPVLF8T4KRR/y/+g/9ArgEeC97da55YUkZr1O2nrB1mcaerH5dKJ IPGxeVgWnPKoGH9W7Ph5KfXrnc6OyxYhiBTWPRfgse8d491nw6RWVrk7xxK6mwAjkA+Y pPlry6OPD/uay0i+PMz1MYFG5AtbI65vKDmZX2LGCjTiskUsMRYzl+yjs/NXi72kRrFU 4RW7SCvdogXorW0WBMq1Hpb+EbjqhdLAeMxxEWNMLwFuQvet+Ws71U3EoJOccCf0GYM/ Cl0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EWB+nOPr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si632151ede.468.2020.09.30.02.22.36; Wed, 30 Sep 2020 02:22:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EWB+nOPr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729068AbgI3JV2 (ORCPT + 99 others); Wed, 30 Sep 2020 05:21:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:36110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727746AbgI3JV1 (ORCPT ); Wed, 30 Sep 2020 05:21:27 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CEE3820754; Wed, 30 Sep 2020 09:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601457687; bh=zywPpSwWaP6wK2pmrgA7OhCg1Alk+yI6mCT5zTybZjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EWB+nOPrkURQtSy1/lM0KgGE2oAt5IfeQVBHlG1eqkg7YmFHjIxTDj2RTg22aL60J Q51BYCLrW1+DQxQ9RRfKl6NHOClhFun4m5NwOSBn2YKKAHzG3XBJ4jpZ5Ryd77bGVM rCc+FU50TnAFLetQzegzrlPip1xgEPNBxNTXiDgM= Date: Wed, 30 Sep 2020 11:21:31 +0200 From: Greg Kroah-Hartman To: Pujin Shi Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, hankinsea@gmail.com Subject: Re: [PATCH] tty: serial: mvebu-uart: Remove unused variable 'ret' Message-ID: <20200930092131.GC1580803@kroah.com> References: <20200930081459.1269-1-shipujin.t@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200930081459.1269-1-shipujin.t@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 04:14:59PM +0800, Pujin Shi wrote: > 'ret' variable is now defined but not used in mvebu_uart_probe(), > causing this warning: > > drivers/tty/serial/mvebu-uart.c: In function ‘mvebu_uart_probe’: > drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable ‘ret’ [-Wunused-variable] > > Signed-off-by: Pujin Shi What commit caused this problem? And are you sure it's not already fixed by: https://lore.kernel.org/r/20200929085651.158283-1-miaoqinglang@huawei.com thanks, greg k-h