Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Sep 2020 12:27:32 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for
 Beelink GS1
Message-ID: <20200930102732.zc3vs4vzm3fyt5dc@gilmour.lan>
References: <20200928150038.97413-1-peron.clem@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="6lpxdfuiykpljni3"
Content-Disposition: inline
In-Reply-To: <20200928150038.97413-1-peron.clem@gmail.com>
Precedence: bulk


--6lpxdfuiykpljni3
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Sep 28, 2020 at 05:00:37PM +0200, Cl=E9ment P=E9ron wrote:
> VQMMC supply is connected to BLDO2 which provides 1.8V.
>=20
> Let's reflect this in the device-tree.

This commit log doesn't really explain what is going on though?

> Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 bo=
ard")
> Signed-off-by: Cl=E9ment P=E9ron <peron.clem@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/ar=
ch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 049c21718846..3f20d2c9bbbb 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -145,6 +145,7 @@ &mmc2 {
>  	vqmmc-supply =3D <&reg_bldo2>;

The Device Tree already expresses that the vqmmc supply is connected to
BLDO2 which provides 1.8V here (together with the reg_bldo2 node).

>  	non-removable;
>  	cap-mmc-hw-reset;
> +	mmc-hs200-1_8v;

Whereas this indicates that the eMMC supports the HS200 MMC mode at 1.8V

Maxime

--6lpxdfuiykpljni3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3RdlAAKCRDj7w1vZxhR
xSesAP9s9WAi1LMpMRDxK5vzmj9DgMppelaptRFG3PuJh0gWFAD+JYOfwFY0H7ya
8OXTPwa/4b3zt5HyzazAGeoEnAtqwAY=
=Chcd
-----END PGP SIGNATURE-----

--6lpxdfuiykpljni3--