Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932175AbWHGQ1l (ORCPT ); Mon, 7 Aug 2006 12:27:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932208AbWHGQ1l (ORCPT ); Mon, 7 Aug 2006 12:27:41 -0400 Received: from mail.gmx.net ([213.165.64.20]:12237 "HELO mail.gmx.net") by vger.kernel.org with SMTP id S932175AbWHGQ1l (ORCPT ); Mon, 7 Aug 2006 12:27:41 -0400 X-Authenticated: #5039886 Date: Mon, 7 Aug 2006 18:27:43 +0200 From: =?iso-8859-1?Q?Bj=F6rn?= Steinbrink To: Shem Multinymous Cc: Pavel Machek , Robert Love , Jean Delvare , Greg Kroah-Hartman , Alan Cox , linux-kernel@vger.kernel.org, hdaps-devel@lists.sourceforge.net Subject: Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access Message-ID: <20060807162743.GA26224@atjola.homenet> Mail-Followup-To: =?iso-8859-1?Q?Bj=F6rn?= Steinbrink , Shem Multinymous , Pavel Machek , Robert Love , Jean Delvare , Greg Kroah-Hartman , Alan Cox , linux-kernel@vger.kernel.org, hdaps-devel@lists.sourceforge.net References: <11548492171301-git-send-email-multinymous@gmail.com> <11548492242899-git-send-email-multinymous@gmail.com> <20060807134440.GD4032@ucw.cz> <41840b750608070813s6d3ffc2enefd79953e0b55caa@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41840b750608070813s6d3ffc2enefd79953e0b55caa@mail.gmail.com> User-Agent: Mutt/1.5.12-2006-07-14 X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 489 Lines: 16 On 2006.08.07 18:13:06 +0300, Shem Multinymous wrote: > >> + struct dmi_device *dev = NULL; > > > >unneeded initializer. > > On a local variable?! You assign a new value to it on the next line, without ever using its initial value. Bj?rn - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/