DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=hQKhcTtW0eYPa5u8syAY+KcbshmRoHtnb+FxLTZL09G5rxSHJDrHxOUfij1MWMh1nfaxfcF5cT33bZnbqeRyaVWmj43OnMUrjEvuiIWmpbUok/xbClftxW5sZY2wiAdY1l0ojC4OCb16rfqWNWw7hizH1ej1ovLDFttdN/rWLW4=
Message-ID: <41840b750608070930p59a250a4l99c07260229dda8e@mail.gmail.com>
Date: Mon, 7 Aug 2006 19:30:55 +0300
From: "Shem Multinymous" <multinymous@gmail.com>
To: "Pavel Machek" <pavel@suse.cz>
Subject: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
Cc: "Robert Love" <rlove@rlove.org>, "Jean Delvare" <khali@linux-fr.org>,
       "Greg Kroah-Hartman" <gregkh@suse.de>,
       "Alan Cox" <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org,
       hdaps-devel@lists.sourceforge.net
In-Reply-To: <20060807140721.GH4032@ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <11548492171301-git-send-email-multinymous@gmail.com>
	 <11548492543835-git-send-email-multinymous@gmail.com>
	 <20060807140721.GH4032@ucw.cz>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 743
Lines: 25

Hi Pavel,

On 8/7/06, Pavel Machek <pavel@suse.cz> wrote:
> > +     int total, ret;
> > +     for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) {
>
> Could we go from 0 to timeout, not the other way around?

Sure.
(That's actually vanilla hdapsd code, moved around...)


> This actually changes userland interface... but that is probably okay.

Those two sysfs attributes were bogus. If anything used them (which I
very much doubt), it's a good thing we broke it.

OK on the rest.

  Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/