Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4587092pxk; Wed, 30 Sep 2020 06:55:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGsin6y7FlGcq87Jf0S7kyqT1qr3STuAJ0h4Gzl7W/8R9qqg5/QQY3G/8/WzBdAKjniMpg X-Received: by 2002:a50:fe0a:: with SMTP id f10mr2880276edt.133.1601474153418; Wed, 30 Sep 2020 06:55:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601474153; cv=none; d=google.com; s=arc-20160816; b=tJDV9WwV7l7oBK83wIB7Nox3AuLdVcIwa2M1zOCWV/rJRlJyKAvGEBljQyGRZ00SXk G350CWQQXJLDwowwAFvsCyg88UnhqFNpaq+65+L+2wSMdrZvT8MY7jKP2T5azxTzuomI y27qdOQ4gOxLnA/BmuUAU2yTntrp9wz4levfr2l+9OW0F8vqQwYwKYJ5jAOf7KbLi2/r o1h/I2wd4amp5ogoTDiulhcbZ7YKuGfLsR/K9ma9FOoBq7dIS7jieE+9XUkDBlTIwhiM zo4EpDEu/hGNR2uJ9lCJgVTvImaokHi4nQfCMM8vSxba0WGP9gjcobLx0VpHmwSxQOHL 1Acw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:dkim-signature; bh=DYvNZ24WcHe1KWr7V2ILrRL6telSJk6Mrq2Xp0T+C5Y=; b=GIVBl1ZRZZ7Z78BCb+kWwLOjRZKCbyq90f5Nwmh1KmQXmry7RnK0+vJFPA8h70iWoj yjGbt4DTdMVqkO+JHWdHWc3004BHLER3d8q1QNkkqZH5TKwVW4tLervJzQNJtEfwNpwX 297IhkH0unJ/ZNF3JfuUZtEbQDI+AUj9tR2FJ8zjqheVkBwMEj3P3Q6uoDYzsVSEf1VO 3gGk5NMLjgIU9KPyTgaVvzbY6VV//RVwYEU+y8tHcUdDbNxOPYsI1HbT1VrrlJ76trGx ukiSOzLsD5Z06Aj+C2PGN1ZTIKQ5yZKjZaHZuHxBpnO4YRHjjndfwuF0mGifPZWUQXfH 2VZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=saqa9v8T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u20si1118935ejt.14.2020.09.30.06.55.30; Wed, 30 Sep 2020 06:55:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=saqa9v8T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730294AbgI3NwL (ORCPT + 99 others); Wed, 30 Sep 2020 09:52:11 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:35182 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728232AbgI3NwK (ORCPT ); Wed, 30 Sep 2020 09:52:10 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UDnbT9006766; Wed, 30 Sep 2020 13:52:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=DYvNZ24WcHe1KWr7V2ILrRL6telSJk6Mrq2Xp0T+C5Y=; b=saqa9v8TSfkZ7qeliqIy18/pBpeDpVTpF7hKL77aNLWruIdNUWz7/1moLn2oitcpk7TG RarCmEuzXPKWCM4Oyj4tLaO1Xfe5uBTPUYWLEI24AwZDA0+2mAOMPpkryltaj9sAygow 28zs+bRmVT/KYsFZ1XaosxdzEOe3ITB/52vuiufwEzr30CWQ0YRGS4VkEgPobGrqas/A SxSX6olqEElHve+elu36LOMa9CEg+3/yl3/5fTcRLqScj4ZCcHhM4ZtJAmyzpxLZNZ+K HuLtvsS3KAvePi/xZr2mk5dK4w6gjFEVoc/gRcIRDM6KbCfI9Wj2wNJnLvzBGYWRjKoQ XA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 33swkm0mc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Sep 2020 13:52:03 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UDotT4030264; Wed, 30 Sep 2020 13:52:02 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33uv2fd8am-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Sep 2020 13:52:02 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08UDq1Iq003108; Wed, 30 Sep 2020 13:52:02 GMT Received: from [10.74.86.12] (/10.74.86.12) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 Sep 2020 06:52:01 -0700 Subject: Re: [PATCH] xen/events: don't use chip_data for legacy IRQs To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Stefano Stabellini , stable@vger.kernel.org References: <20200930091614.13660-1-jgross@suse.com> From: boris.ostrovsky@oracle.com Organization: Oracle Corporation Message-ID: Date: Wed, 30 Sep 2020 09:51:54 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20200930091614.13660-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300109 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300109 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/20 5:16 AM, Juergen Gross wrote: > Since commit c330fb1ddc0a ("XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.") > Xen is using the chip_data pointer for storing IRQ specific data. When > running as a HVM domain this can result in problems for legacy IRQs, as > those might use chip_data for their own purposes. > > Use a local array for this purpose in case of legacy IRQs, avoiding the > double use. > > Cc: stable@vger.kernel.org > Fixes: c330fb1ddc0a ("XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.") > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky