Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200929082025.51446-1-aaron.ma@canonical.com>
In-Reply-To: <20200929082025.51446-1-aaron.ma@canonical.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 30 Sep 2020 16:55:27 +0300
Message-ID: <CAHp75Vf2eCDHuqdtrCXqg7FNiDoSg5BDmtXLJ7AMuF8He9qy=w@mail.gmail.com>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: re-initialize acpi buffer
 size when reuse
To:     Aaron Ma <aaron.ma@canonical.com>
Cc:     mapengyu@gmail.com,
        Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        Thinkpad-acpi devel ML <ibm-acpi-devel@lists.sourceforge.net>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 29, 2020 at 11:20 AM Aaron Ma <aaron.ma@canonical.com> wrote:
>
> Evaluating acpi _BCL could be failed, then acpi buffer size will be set

'could be failed' -> 'could fail'

> to 0. When reuse this acpi buffer, AE_BUFFER_OVERFLOW will be triggered.
>
> Re-initialize buffer size will make acpi evaluate successfully.

acpi -> ACPI in all cases above.

Fixes tag, please?

> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

Code is okay.

-- 
With Best Regards,
Andy Shevchenko