Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 07/11] firmware: ti_sci: rm: Add new ops for ring
 configuration
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>, <nm@ti.com>,
        <t-kristo@ti.com>, <ssantosh@kernel.org>, <lokeshvutla@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20200928083429.17390-1-peter.ujfalusi@ti.com>
 <20200928083429.17390-8-peter.ujfalusi@ti.com>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <e38f9096-8b12-309f-f910-b7fe0843c902@ti.com>
Date:   Wed, 30 Sep 2020 16:54:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200928083429.17390-8-peter.ujfalusi@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 28/09/2020 11:34, Peter Ujfalusi wrote:
> The sysfw ring configuration message has been extended to include virtid
> and asel value for the ring.
> Add the ASEL_VALID to TI_SCI_MSG_VALUE_RM_ALL_NO_ORDER as it is required
> for DMA rings.
> 
> Instead of extending the current .config() ops - which would need same
> patch change in the ringacc driver - add ti_sci_msg_rm_ring_cfg struct and
> a new ops using it to configure the ring.
> 
> This will allow easy update path in case new members are added for the ring
> configuration.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>   drivers/firmware/ti_sci.c              | 63 ++++++++++++++++++++++++++
>   drivers/firmware/ti_sci.h              |  7 +++
>   include/linux/soc/ti/ti_sci_protocol.h | 31 ++++++++++++-
>   3 files changed, 100 insertions(+), 1 deletion(-)
> 
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii